Louis Kotze <loukot@gmail.com> wrote:
> Only the EML capabilities patch has an explicit improvement: in A/B
> testing on my RTL8922AU against a TP-Link Deco BE63, ML association
> without it came up with a single link, and with it both the 5 GHz
> and 6 GHz links are set up (debugfs link-1/link-2, active_links
> behaving as expected for EMLSR), stable across 60+ hour soaks. The
> other three were no-regression only, which is part of why v2 drops
> them.

It is also like other features. 

With this declaration, it will handshake two links in protocol point
of view, so you can see two links in debugfs, but actually it operates
on one of the links since driver isn't implemented to configure
hardware and firmware. 

> v2 is therefore that single patch, and follows.

So, I'd defer this patch. Internally, we are still cooking to enable
this feature.

Ping-Ke

Ping-Ke Shih <pkshih@realtek.com> wrote:
> With this declaration, it will handshake two links in protocol point
> of view, so you can see two links in debugfs, but actually it operates
> on one of the links since driver isn't implemented to configure
> hardware and firmware.
>
> So, I'd defer this patch. Internally, we are still cooking to enable
> this feature.

Understood, and that makes sense. Advertising the capability without the
hardware and firmware configuration behind it would be misleading to the
peer, and my A/B only established that the links are set up at the
protocol level, which is exactly the part you are granting. I did not
measure per-link radio activity, so I have nothing that speaks to whether
EMLSR actually runs.

Dropping the patch, and I will not resend it.

When the EMLSR enablement is ready, I am happy to test it. I have an
RTL8922AU (USB) associated to a Wi-Fi 7 AP MLD with an A/B capture rig
already set up, so I can report on real multi-link behaviour rather than
just the association state. Please Cc me if that would be useful.

Thanks for taking the time on the series.

Louis

(Resent as plain text; the original copy was rejected by the list for
containing an HTML part. Apologies for the duplicate, Ping-Ke.)