cgroup/rdma: Drop bogus PAGE_COUNTER select

[PATCH next] cgroup/rdma: Drop bogus PAGE_COUNTER select

Posted by Geert Uytterhoeven 1 year ago

When adding the Device memory controller (DMEM), "select PAGE_COUNTER"
was added to CGROUP_RDMA, presumably instead of CGROUP_DMEM.
While commit e33b51499a0a6bca ("cgroup/dmem: Select PAGE_COUNTER") added
the missing select to CGROUP_DMEM, the bogus select is still there.
Remove it.

Fixes: b168ed458ddecc17 ("kernel/cgroup: Add "dmem" memory accounting cgroup")
Closes: https://lore.kernel.org/CAMuHMdUmPfahsnZwx2iB5yfh8rjjW25LNcnYujNBgcKotUXBNg@mail.gmail.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Broken commit is in drm/drm-next
Partial fix is in drm-misc/for-linux-next

 init/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index 61f50cafa8151ed2..bd7630e75207e8dc 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1128,7 +1128,6 @@ config CGROUP_PIDS
 
 config CGROUP_RDMA
 	bool "RDMA controller"
-	select PAGE_COUNTER
 	help
 	  Provides enforcement of RDMA resources defined by IB stack.
 	  It is fairly easy for consumers to exhaust RDMA resources, which
-- 
2.43.0

Re: [PATCH next] cgroup/rdma: Drop bogus PAGE_COUNTER select

Posted by Maxime Ripard 1 year ago

On Thu, 16 Jan 2025 10:56:35 +0100, Geert Uytterhoeven wrote:
> When adding the Device memory controller (DMEM), "select PAGE_COUNTER"
> was added to CGROUP_RDMA, presumably instead of CGROUP_DMEM.
> While commit e33b51499a0a6bca ("cgroup/dmem: Select PAGE_COUNTER") added
> the missing select to CGROUP_DMEM, the bogus select is still there.
> Remove it.
> 
> 
> [...]

Applied to misc/kernel.git (drm-misc-next-fixes).

Thanks!
Maxime

Re: [PATCH next] cgroup/rdma: Drop bogus PAGE_COUNTER select

Posted by Tejun Heo 1 year ago

On Thu, Jan 16, 2025 at 10:56:35AM +0100, Geert Uytterhoeven wrote:
> When adding the Device memory controller (DMEM), "select PAGE_COUNTER"
> was added to CGROUP_RDMA, presumably instead of CGROUP_DMEM.
> While commit e33b51499a0a6bca ("cgroup/dmem: Select PAGE_COUNTER") added
> the missing select to CGROUP_DMEM, the bogus select is still there.
> Remove it.
> 
> Fixes: b168ed458ddecc17 ("kernel/cgroup: Add "dmem" memory accounting cgroup")
> Closes: https://lore.kernel.org/CAMuHMdUmPfahsnZwx2iB5yfh8rjjW25LNcnYujNBgcKotUXBNg@mail.gmail.com
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun