media: stm32: csi: Omit two variable reassignments in stm32_csi_probe()

[PATCH] media: stm32: csi: Omit two variable reassignments in stm32_csi_probe()

Posted by Markus Elfring 3 months, 2 weeks ago

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 20 Oct 2025 14:30:06 +0200

An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete two redundant variable reassignments.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/platform/st/stm32/stm32-csi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/st/stm32/stm32-csi.c b/drivers/media/platform/st/stm32/stm32-csi.c
index fd2b6dfbd44c..a997b34a73d7 100644
--- a/drivers/media/platform/st/stm32/stm32-csi.c
+++ b/drivers/media/platform/st/stm32/stm32-csi.c
@@ -1033,8 +1033,7 @@ static int stm32_csi_probe(struct platform_device *pdev)
 
 	ret = reset_control_assert(rstc);
 	if (ret) {
-		ret = dev_err_probe(&pdev->dev, ret,
-				    "Failed to assert the reset line\n");
+		dev_err_probe(&pdev->dev, ret, "Failed to assert the reset line\n");
 		goto err_cleanup;
 	}
 
@@ -1042,8 +1041,7 @@ static int stm32_csi_probe(struct platform_device *pdev)
 
 	ret = reset_control_deassert(rstc);
 	if (ret) {
-		ret = dev_err_probe(&pdev->dev, ret,
-				    "Failed to deassert the reset line\n");
+		dev_err_probe(&pdev->dev, ret, "Failed to deassert the reset line\n");
 		goto err_cleanup;
 	}
 
-- 
2.51.1

Re: [PATCH] media: stm32: csi: Omit two variable reassignments in stm32_csi_probe()

Posted by Alain Volmat 3 months, 1 week ago

Hi Markus,

thanks for this patch.

On Mon, Oct 20, 2025 at 02:38:08PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 20 Oct 2025 14:30:06 +0200
> 
> An error code was assigned to a variable and checked accordingly.
> This value was passed to a dev_err_probe() call in an if branch.
> This function is documented in the way that the same value is returned.
> Thus delete two redundant variable reassignments.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/media/platform/st/stm32/stm32-csi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/st/stm32/stm32-csi.c b/drivers/media/platform/st/stm32/stm32-csi.c
> index fd2b6dfbd44c..a997b34a73d7 100644
> --- a/drivers/media/platform/st/stm32/stm32-csi.c
> +++ b/drivers/media/platform/st/stm32/stm32-csi.c
> @@ -1033,8 +1033,7 @@ static int stm32_csi_probe(struct platform_device *pdev)
>  
>  	ret = reset_control_assert(rstc);
>  	if (ret) {
> -		ret = dev_err_probe(&pdev->dev, ret,
> -				    "Failed to assert the reset line\n");
> +		dev_err_probe(&pdev->dev, ret, "Failed to assert the reset line\n");
>  		goto err_cleanup;
>  	}
>  
> @@ -1042,8 +1041,7 @@ static int stm32_csi_probe(struct platform_device *pdev)
>  
>  	ret = reset_control_deassert(rstc);
>  	if (ret) {
> -		ret = dev_err_probe(&pdev->dev, ret,
> -				    "Failed to deassert the reset line\n");
> +		dev_err_probe(&pdev->dev, ret, "Failed to deassert the reset line\n");
>  		goto err_cleanup;
>  	}
>  
> -- 
> 2.51.1
> 

Acked-by: Alain Volmat <alain.volmat@foss.st.com>

Regards,
Alain