[v2] iio: light: ltr390: Remove stale TODOs

[PATCH v2] iio: light: ltr390: Remove stale TODOs

Posted by Chang Yu 4 weeks, 1 day ago

Remove stale TODOs from ltr390.c. All features have already been
implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:

Configurable gain and resoluion: commit 13fad2607dad ("iio: light:
ltr390: Add configurable gain and resolution") 

Suspend/resume support: commit 288ce72fb5fc ("iio: light: ltr390:
Suspend and Resume support")

Support for reading the ALS: commit 14e0d914a855 ("iio: light: ltr390:
Add ALS channel and support for gain and resolution")

Interrupt support: commit 7ca4b8957066 ("iio: light: ltr390: Interrupts
and threshold event support")

Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
---

Changes since v2:
  * Added commit hashes for each implemented feature.

 drivers/iio/light/ltr390.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/iio/light/ltr390.c b/drivers/iio/light/ltr390.c
index bc031f2c3141..f1bb066248e6 100644
--- a/drivers/iio/light/ltr390.c
+++ b/drivers/iio/light/ltr390.c
@@ -10,12 +10,6 @@
  *
  * Datasheet:
  *   https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf
- *
- * TODO:
- *   - Support for configurable gain and resolution
- *   - Sensor suspend/resume support
- *   - Add support for reading the ALS
- *   - Interrupt support
  */
 
 #include <linux/bitfield.h>
-- 
2.55.0

Re: [PATCH v2] iio: light: ltr390: Remove stale TODOs

Posted by Andy Shevchenko 4 weeks, 1 day ago

On Fri, Aug 28, 2026 at 12:10:47AM -0700, Chang Yu wrote:
> Remove stale TODOs from ltr390.c. All features have already been
> implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:
> 
> Configurable gain and resoluion: commit 13fad2607dad ("iio: light:

Misspelled 'resolution'.

> ltr390: Add configurable gain and resolution") 

Here is trailing white space. Also you can do it in a way

 [1] Configurable gain and resolution
 [2] Suspend/resume support
 [3] Support for reading the ALS
 [4] Interrupt support

Link: https://git.kernel.org/torvalds/c/13fad2607dad [1]
Link: https://git.kernel.org/torvalds/c/288ce72fb5fc [2]
Link: https://git.kernel.org/torvalds/c/14e0d914a855 [3]
Link: https://git.kernel.org/torvalds/c/7ca4b8957066 [4]

> Suspend/resume support: commit 288ce72fb5fc ("iio: light: ltr390:
> Suspend and Resume support")
> 
> Support for reading the ALS: commit 14e0d914a855 ("iio: light: ltr390:
> Add ALS channel and support for gain and resolution")
> 
> Interrupt support: commit 7ca4b8957066 ("iio: light: ltr390: Interrupts
> and threshold event support")

-- 
With Best Regards,
Andy Shevchenko