drm/amd/pm: silence uninitialized variable warnings

[PATCH] drm/amd/pm: silence uninitialized variable warnings

Posted by Dan Carpenter 1 month, 3 weeks ago

Smatch complains that:

    drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu15/smu_v15_0_8_ppt.c:1964
    smu_v15_0_8_set_performance_level() error: uninitialized symbol 'ret'.

In this line there is an "if (ret)" condition where "ret" is either
zero or uninitialized.  Initialize "ret" at the start of the function to
avoid a potential uninitialized variable bug.  But also delete the
condition since it is never true.

Fixes: 422b399b09c7 ("drm/amd/pm: Add od_edit_dpm_table support")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
index 59fdd2319b66..c78e611d2a25 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
@@ -1920,7 +1920,7 @@ static int smu_v15_0_8_set_performance_level(struct smu_context *smu,
 	struct smu_dpm_table *gfx_table = &dpm_context->dpm_tables.gfx_table;
 	struct smu_dpm_table *uclk_table = &dpm_context->dpm_tables.uclk_table;
 	struct smu_umd_pstate_table *pstate_table = &smu->pstate_table;
-	int ret;
+	int ret = 0;
 
 	switch (level) {
 	case AMD_DPM_FORCED_LEVEL_PERF_DETERMINISM:
@@ -1961,9 +1961,6 @@ static int smu_v15_0_8_set_performance_level(struct smu_context *smu,
 				SMU_DPM_TABLE_MAX(uclk_table);
 		}
 
-		if (ret)
-			goto out;
-
 		smu_cmn_reset_custom_level(smu);
 
 		break;
-- 
2.53.0

Re: [PATCH] drm/amd/pm: silence uninitialized variable warnings

Posted by Lazar, Lijo 1 month, 2 weeks ago


On 09-Aug-26 1:11 AM, Dan Carpenter wrote:
> Smatch complains that:
> 
>      drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu15/smu_v15_0_8_ppt.c:1964
>      smu_v15_0_8_set_performance_level() error: uninitialized symbol 'ret'.
> 
> In this line there is an "if (ret)" condition where "ret" is either
> zero or uninitialized.  Initialize "ret" at the start of the function to
> avoid a potential uninitialized variable bug.  But also delete the
> condition since it is never true.
> 
> Fixes: 422b399b09c7 ("drm/amd/pm: Add od_edit_dpm_table support")
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> index 59fdd2319b66..c78e611d2a25 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> @@ -1920,7 +1920,7 @@ static int smu_v15_0_8_set_performance_level(struct smu_context *smu,
>   	struct smu_dpm_table *gfx_table = &dpm_context->dpm_tables.gfx_table;
>   	struct smu_dpm_table *uclk_table = &dpm_context->dpm_tables.uclk_table;
>   	struct smu_umd_pstate_table *pstate_table = &smu->pstate_table;
> -	int ret;
> +	int ret = 0;
>   
>   	switch (level) {
>   	case AMD_DPM_FORCED_LEVEL_PERF_DETERMINISM:
> @@ -1961,9 +1961,6 @@ static int smu_v15_0_8_set_performance_level(struct smu_context *smu,
>   				SMU_DPM_TABLE_MAX(uclk_table);
>   		}
>   
> -		if (ret)
> -			goto out;
> -
>   		smu_cmn_reset_custom_level(smu);
>   
>   		break;

Re: [PATCH] drm/amd/pm: silence uninitialized variable warnings

Posted by Alex Deucher 1 month, 2 weeks ago

Applied.  Thanks!

Alex

On Mon, Aug 10, 2026 at 12:50 AM Lazar, Lijo <lijo.lazar@amd.com> wrote:
>
>
>
> On 09-Aug-26 1:11 AM, Dan Carpenter wrote:
> > Smatch complains that:
> >
> >      drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu15/smu_v15_0_8_ppt.c:1964
> >      smu_v15_0_8_set_performance_level() error: uninitialized symbol 'ret'.
> >
> > In this line there is an "if (ret)" condition where "ret" is either
> > zero or uninitialized.  Initialize "ret" at the start of the function to
> > avoid a potential uninitialized variable bug.  But also delete the
> > condition since it is never true.
> >
> > Fixes: 422b399b09c7 ("drm/amd/pm: Add od_edit_dpm_table support")
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
>
> Thanks,
> Lijo
>
> > ---
> >   drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 5 +----
> >   1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> > index 59fdd2319b66..c78e611d2a25 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> > @@ -1920,7 +1920,7 @@ static int smu_v15_0_8_set_performance_level(struct smu_context *smu,
> >       struct smu_dpm_table *gfx_table = &dpm_context->dpm_tables.gfx_table;
> >       struct smu_dpm_table *uclk_table = &dpm_context->dpm_tables.uclk_table;
> >       struct smu_umd_pstate_table *pstate_table = &smu->pstate_table;
> > -     int ret;
> > +     int ret = 0;
> >
> >       switch (level) {
> >       case AMD_DPM_FORCED_LEVEL_PERF_DETERMINISM:
> > @@ -1961,9 +1961,6 @@ static int smu_v15_0_8_set_performance_level(struct smu_context *smu,
> >                               SMU_DPM_TABLE_MAX(uclk_table);
> >               }
> >
> > -             if (ret)
> > -                     goto out;
> > -
> >               smu_cmn_reset_custom_level(smu);
> >
> >               break;
>