This loop timeout with "retries" set to -1, not 0.  Fix the test
for failure.

Fixes: 7ec0effd30bb ("[SCSI] qla2xxx: Add support for ISP8044.")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
 drivers/scsi/qla2xxx/qla_nx2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c
index 41ff6fbdb933..04d7ab6ad037 100644
--- a/drivers/scsi/qla2xxx/qla_nx2.c
+++ b/drivers/scsi/qla2xxx/qla_nx2.c
@@ -3507,7 +3507,7 @@ qla8044_poll_flash_status_reg(struct scsi_qla_host *vha)
 		msleep(QLA8044_FLASH_STATUS_REG_POLL_DELAY);
 	}
 
-	if (!retries)
+	if (retries == -1)
 		ret_val = QLA_FUNCTION_FAILED;
 
 	return ret_val;
-- 
2.53.0

On Thu, 13 Aug 2026 10:09:53 +0300, Dan Carpenter wrote:

> This loop timeout with "retries" set to -1, not 0.  Fix the test
> for failure.

Applied to 7.3/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Fix an loop timeout test
      https://git.kernel.org/mkp/scsi/c/11e48f5201fd

-- 
Martin K. Petersen

Dan,

> This loop timeout with "retries" set to -1, not 0. Fix the test for
> failure.

Applied to 7.3/scsi-staging, thanks!

-- 
Martin K. Petersen