The "ver" variable is type "enum ddr_info_version".  Enum types are
dependent on the compiler but in practical terms here, "ver" is
basically an unsigned int.  It needs to be signed for the -EINVAL
to be handled correctly.

Fixes: 1d234eeafc56 ("soc: qcom: smem: Expose DDR data from SMEM")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
 drivers/soc/qcom/smem_dramc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/smem_dramc.c b/drivers/soc/qcom/smem_dramc.c
index 63ebe7f6db59..6283e9317f19 100644
--- a/drivers/soc/qcom/smem_dramc.c
+++ b/drivers/soc/qcom/smem_dramc.c
@@ -382,7 +382,7 @@ struct dentry *smem_dram_parse(struct qcom_smem *smem, struct device *dev)
 		return ERR_PTR(-ENODATA);
 
 	ver = smem_dram_infer_struct_version(actual_size);
-	if (ver < 0) {
+	if ((int)ver < 0) {
 		/* Some SoCs don't provide data that's useful for us */
 		return ERR_PTR(-ENODATA);
 	} else if (ver == INFO_UNKNOWN) {
-- 
2.53.0

On Thu, 13 Aug 2026 10:09:21 +0300, Dan Carpenter wrote:
> The "ver" variable is type "enum ddr_info_version".  Enum types are
> dependent on the compiler but in practical terms here, "ver" is
> basically an unsigned int.  It needs to be signed for the -EINVAL
> to be handled correctly.
> 
> 

Applied, thanks!

[1/1] soc: qcom: smem: Fix signedness bug in smem_dram_parse()
      commit: 22f129fedb153a17d80b1d883a7c4dd2417cf38e

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

On 8/13/26 9:09 AM, Dan Carpenter wrote:
> The "ver" variable is type "enum ddr_info_version".  Enum types are
> dependent on the compiler but in practical terms here, "ver" is
> basically an unsigned int.  It needs to be signed for the -EINVAL
> to be handled correctly.
> 
> Fixes: 1d234eeafc56 ("soc: qcom: smem: Expose DDR data from SMEM")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad