drivers/scsi/qla2xxx/qla_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Negative -EIO was intended instead of positive EIO. The caller, doesn't
care so this doesn't affect runtime. It's just a cleanup.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 2b9a9c672ec6..0c4e8ce9decf 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -2302,7 +2302,7 @@ int qla_get_tmf(struct tmf_arg *arg)
if (TMF_NOT_READY(fcport)) {
ql_log(ql_log_warn, vha, 0x802c,
"Unable to acquire TM resource due to disruption.\n");
- rc = EIO;
+ rc = -EIO;
break;
}
if (ha->active_tmf < MAX_ACTIVE_TMF &&
--
2.53.0
On Thu, 13 Aug 2026 10:08:27 +0300, Dan Carpenter wrote:
> Negative -EIO was intended instead of positive EIO. The caller, doesn't
> care so this doesn't affect runtime. It's just a cleanup.
Applied to 7.3/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Fix an error code in qla_get_tmf()
https://git.kernel.org/mkp/scsi/c/ff9365a4c999
--
Martin K. Petersen
Dan, > Negative -EIO was intended instead of positive EIO. The caller, > doesn't care so this doesn't affect runtime. It's just a cleanup. Applied to 7.3/scsi-staging, thanks! -- Martin K. Petersen
© 2016 - 2026 Red Hat, Inc.