parport_pc: Limit the number of PCI BAR pairs to 2

[PATCH] parport_pc: Limit the number of PCI BAR pairs to 2

Posted by Maciej W. Rozycki 3 years, 4 months ago

Decrease the number of PCI BAR pair slots allocated for port subdrivers 
from 4 to 2 as none wants more than 2 at this time, reducing the memory 
footprint a little.  No functional change.

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
---
 drivers/parport/parport_pc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

linux-parport-pc-pci-bars.diff
Index: linux-macro/drivers/parport/parport_pc.c
===================================================================
--- linux-macro.orig/drivers/parport/parport_pc.c
+++ linux-macro/drivers/parport/parport_pc.c
@@ -2657,7 +2657,7 @@ static struct parport_pc_pci {
 		int lo;
 		int hi;
 		/* -1 if not there, >6 for offset-method (max BAR is 6) */
-	} addr[4];
+	} addr[2];
 
 	/* Bit field of parport modes to exclude. */
 	unsigned int mode_mask;

[PATCH][PATCH] parport_pc: Limit the number of PCI BAR pairs to 2

Posted by Maciej W. Rozycki 3 years, 3 months ago

On Wed, 16 Nov 2022, Maciej W. Rozycki wrote:

> Decrease the number of PCI BAR pair slots allocated for port subdrivers 
> from 4 to 2 as none wants more than 2 at this time, reducing the memory 
> footprint a little.  No functional change.

 Ping for: 
<https://lore.kernel.org/lkml/alpine.DEB.2.21.2209260132340.29493@angie.orcam.me.uk/>.

  Maciej

Re: [PATCH][PATCH] parport_pc: Limit the number of PCI BAR pairs to 2

Posted by Sudip Mukherjee 3 years, 3 months ago

On Fri, 6 Jan 2023 at 01:12, Maciej W. Rozycki <macro@orcam.me.uk> wrote:
>
> On Wed, 16 Nov 2022, Maciej W. Rozycki wrote:
>
> > Decrease the number of PCI BAR pair slots allocated for port subdrivers
> > from 4 to 2 as none wants more than 2 at this time, reducing the memory
> > footprint a little.  No functional change.
>
>  Ping for:
> <https://lore.kernel.org/lkml/alpine.DEB.2.21.2209260132340.29493@angie.orcam.me.uk/>.

Sorry for the delay. Had to dig out my hardwares for the other series.
This and the other series
looks ok. Will test tonight and I will send it to Greg.


-- 
Regards
Sudip

Re: [PATCH][PATCH] parport_pc: Limit the number of PCI BAR pairs to 2

Posted by Maciej W. Rozycki 3 years, 3 months ago

On Sat, 7 Jan 2023, Sudip Mukherjee wrote:

> > > Decrease the number of PCI BAR pair slots allocated for port subdrivers
> > > from 4 to 2 as none wants more than 2 at this time, reducing the memory
> > > footprint a little.  No functional change.
> >
> >  Ping for:
> > <https://lore.kernel.org/lkml/alpine.DEB.2.21.2209260132340.29493@angie.orcam.me.uk/>.
> 
> Sorry for the delay. Had to dig out my hardwares for the other series.
> This and the other series
> looks ok. Will test tonight and I will send it to Greg.

 No worries, and thank you for your review!

  Maciej