[PATCH] Alpha: Remove redundant local asm header redirections

Maciej W. Rozycki posted 1 patch 4 years, 4 months ago
Failed in applying to current master (apply log)
arch/alpha/include/asm/Kbuild        |    1 +
arch/alpha/include/asm/asm-offsets.h |    1 -
arch/alpha/include/asm/div64.h       |    1 -
arch/alpha/include/asm/irq_regs.h    |    1 -
arch/alpha/include/asm/kdebug.h      |    1 -
5 files changed, 1 insertion(+), 4 deletions(-)
[PATCH] Alpha: Remove redundant local asm header redirections
Posted by Maciej W. Rozycki 4 years, 4 months ago
Remove a number of asm headers locally redirected to the respective 
generic or generated versions.

For asm-offsets.h all that is needed is a Kbuild entry for the generic 
version, and for div64.h, irq_regs.h and kdebug.h nothing is needed as 
in their absence they will be redirected automatically according to 
include/asm-generic/Kbuild.

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
---
Hi,

 Noticed while fiddling with Kbuild for PARPORT_PC.  Please apply.

  Maciej
---
 arch/alpha/include/asm/Kbuild        |    1 +
 arch/alpha/include/asm/asm-offsets.h |    1 -
 arch/alpha/include/asm/div64.h       |    1 -
 arch/alpha/include/asm/irq_regs.h    |    1 -
 arch/alpha/include/asm/kdebug.h      |    1 -
 5 files changed, 1 insertion(+), 4 deletions(-)

linux-alpha-include-gen.diff
Index: linux-macro/arch/alpha/include/asm/Kbuild
===================================================================
--- linux-macro.orig/arch/alpha/include/asm/Kbuild
+++ linux-macro/arch/alpha/include/asm/Kbuild
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 
 generated-y += syscall_table.h
+generic-y += asm-offsets.h
 generic-y += export.h
 generic-y += kvm_para.h
 generic-y += mcs_spinlock.h
Index: linux-macro/arch/alpha/include/asm/asm-offsets.h
===================================================================
--- linux-macro.orig/arch/alpha/include/asm/asm-offsets.h
+++ /dev/null
@@ -1 +0,0 @@
-#include <generated/asm-offsets.h>
Index: linux-macro/arch/alpha/include/asm/div64.h
===================================================================
--- linux-macro.orig/arch/alpha/include/asm/div64.h
+++ /dev/null
@@ -1 +0,0 @@
-#include <asm-generic/div64.h>
Index: linux-macro/arch/alpha/include/asm/irq_regs.h
===================================================================
--- linux-macro.orig/arch/alpha/include/asm/irq_regs.h
+++ /dev/null
@@ -1 +0,0 @@
-#include <asm-generic/irq_regs.h>
Index: linux-macro/arch/alpha/include/asm/kdebug.h
===================================================================
--- linux-macro.orig/arch/alpha/include/asm/kdebug.h
+++ /dev/null
@@ -1 +0,0 @@
-#include <asm-generic/kdebug.h>
Re: [PATCH] Alpha: Remove redundant local asm header redirections
Posted by Matt Turner 4 years, 2 months ago
On Sun, Feb 13, 2022 at 12:01 PM Maciej W. Rozycki <macro@orcam.me.uk> wrote:
>
> Remove a number of asm headers locally redirected to the respective
> generic or generated versions.
>
> For asm-offsets.h all that is needed is a Kbuild entry for the generic
> version, and for div64.h, irq_regs.h and kdebug.h nothing is needed as
> in their absence they will be redirected automatically according to
> include/asm-generic/Kbuild.
>
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> ---
> Hi,
>
>  Noticed while fiddling with Kbuild for PARPORT_PC.  Please apply.
>
>   Maciej


Sorry for the delay. I'll apply this. I just haven't had much time for
alphas lately.

Maybe now's a good time to remind you that I'm still waiting on you to
upstream the m41t80/SWARM/i2c/smbus patches? It's been more than 11
years now, so it seems long enough for a ping :)
Re: [PATCH] Alpha: Remove redundant local asm header redirections
Posted by Maciej W. Rozycki 4 years, 2 months ago
On Thu, 14 Apr 2022, Matt Turner wrote:

> Sorry for the delay. I'll apply this. I just haven't had much time for
> alphas lately.

 No worries, and thanks for chiming in.  I plan to get one of my Alphas 
set up and wired in my remote lab later this year, so I hope to get a bit 
more active with the port.  At least I've got a reasonably recent build of 
the toolchain:

$ alpha-linux-gnu-gcc --version
alpha-linux-gnu-gcc (GCC) 12.0.1 20220129 (experimental)
[...]

> Maybe now's a good time to remind you that I'm still waiting on you to
> upstream the m41t80/SWARM/i2c/smbus patches? It's been more than 11
> years now, so it seems long enough for a ping :)

 Umm, right, I came across them recently!  I'll see what I can do, however 
I don't have my SWARM in my remote lab, so I can only verify things when 
I'm next to it (which has been occasional only since the start of the 
bloody pandemic).  As I recall there was an issue with the incompatibility 
of the SMBUS protocol subset implemented by the SOC and the RTC causing a 
race.  I've had more stuff outstanding, such as PHY IRQ support for the 
Ethernet interfaces.

 And I yet have to see why my compiler miscompiled one endianness of CFE 
too (and find a way to publish my CFE fixes)!

  Maciej
Re: [PATCH] Alpha: Remove redundant local asm header redirections
Posted by Matt Turner 3 years, 4 months ago
On Fri, Apr 15, 2022 at 8:26 AM Maciej W. Rozycki <macro@orcam.me.uk> wrote:
>
> On Thu, 14 Apr 2022, Matt Turner wrote:
>
> > Sorry for the delay. I'll apply this. I just haven't had much time for
> > alphas lately.
>
>  No worries, and thanks for chiming in.  I plan to get one of my Alphas
> set up and wired in my remote lab later this year, so I hope to get a bit
> more active with the port.  At least I've got a reasonably recent build of
> the toolchain:
>
> $ alpha-linux-gnu-gcc --version
> alpha-linux-gnu-gcc (GCC) 12.0.1 20220129 (experimental)
> [...]

Thanks for the patch! This was included in my pull request today and
is now upstream in Linus' tree.
Re: [PATCH] Alpha: Remove redundant local asm header redirections
Posted by Maciej W. Rozycki 3 years, 4 months ago
On Sat, 25 Feb 2023, Matt Turner wrote:

> >  No worries, and thanks for chiming in.  I plan to get one of my Alphas
> > set up and wired in my remote lab later this year, so I hope to get a bit
> > more active with the port.  At least I've got a reasonably recent build of
> > the toolchain:
> >
> > $ alpha-linux-gnu-gcc --version
> > alpha-linux-gnu-gcc (GCC) 12.0.1 20220129 (experimental)
> > [...]
> 
> Thanks for the patch! This was included in my pull request today and
> is now upstream in Linus' tree.

 Great, thanks!  And BTW my Alpha has been relocated and was scheduled for 
wiring back in Jan, but events beyond my control have prevented this from 
happening.  I have it planned late Mar now, so fingers crossed I'll be 
able to do some more soon.

  Maciej
[PING^3][PATCH] Alpha: Remove redundant local asm header redirections
Posted by Maciej W. Rozycki 4 years, 2 months ago
On Sun, 13 Feb 2022, Maciej W. Rozycki wrote:

> Remove a number of asm headers locally redirected to the respective 
> generic or generated versions.

 Ping for:
<https://lore.kernel.org/lkml/alpine.DEB.2.21.2202131944000.34636@angie.orcam.me.uk/>

  Maciej
Re: [PING^3][PATCH] Alpha: Remove redundant local asm header redirections
Posted by John Paul Adrian Glaubitz 4 years, 2 months ago
Hi Maciej!

On 4/14/22 00:53, Maciej W. Rozycki wrote:
> On Sun, 13 Feb 2022, Maciej W. Rozycki wrote:
> 
>> Remove a number of asm headers locally redirected to the respective 
>> generic or generated versions.
> 
>  Ping for:
> <https://lore.kernel.org/lkml/alpine.DEB.2.21.2202131944000.34636@angie.orcam.me.uk/>

Maybe Andrew Morton could pick the fix up if the original maintainer is currently
not responding?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
[PING][PATCH] Alpha: Remove redundant local asm header redirections
Posted by Maciej W. Rozycki 4 years, 3 months ago
On Sun, 13 Feb 2022, Maciej W. Rozycki wrote:

> Remove a number of asm headers locally redirected to the respective 
> generic or generated versions.

 Ping for:

<https://lore.kernel.org/lkml/alpine.DEB.2.21.2202131944000.34636@angie.orcam.me.uk/>

  Maciej
[PING^2][PATCH] Alpha: Remove redundant local asm header redirections
Posted by Maciej W. Rozycki 4 years, 2 months ago
On Sun, 13 Feb 2022, Maciej W. Rozycki wrote:

> Remove a number of asm headers locally redirected to the respective 
> generic or generated versions.

 Ping for: 
<https://lore.kernel.org/lkml/alpine.DEB.2.21.2202131944000.34636@angie.orcam.me.uk/>

 BTW, has anybody heard from Richard Henderson lately?  His twiddle.net 
domain no longer resolves, and it was like this with the previous ping 
already.

  Maciej