[PATCH] Bluetooth: btrtl: fix uninitialized scalar value

Alonso Garrigues posted 1 patch 1 month, 3 weeks ago
drivers/bluetooth/btrtl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Bluetooth: btrtl: fix uninitialized scalar value
Posted by Alonso Garrigues 1 month, 3 weeks ago
There is a path where the variable is read uninitialized:
If the opcode switch case is RTL_PATCH_SECURITY_HEADER and key_id is
not set, the if statement condition immediately following the switch
checks an uninitialized rc

Signed-off-by: Alonso Garrigues <agarrigues@riseup.net>
---
 drivers/bluetooth/btrtl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 62f9d4df3a4f..aa0d5af26b5f 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -543,7 +543,7 @@ static int rtlbt_parse_firmware_v2(struct hci_dev *hdev,
 				   unsigned char **_buf)
 {
 	struct rtl_epatch_header_v2 *hdr;
-	int rc;
+	int rc = 0;
 	u8 key_id;
 	u32 num_sections;
 	struct rtl_section *section;
-- 
2.53.0