[v1] sfc: fix error code in efx_devlink_info_running_versions()

[PATCH net] sfc: fix error code in efx_devlink_info_running_versions()

Posted by Dan Carpenter 1 month, 3 weeks ago

Return -EINVAL if efx_mcdi_rpc() doesn't return enough space.

Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
 drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
index d842c60dfc10..45f412bb9b5d 100644
--- a/drivers/net/ethernet/sfc/efx_devlink.c
+++ b/drivers/net/ethernet/sfc/efx_devlink.c
@@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,
 	if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) {
 		netif_err(efx, drv, efx->net_dev,
 			  "mcdi MC_CMD_GET_VERSION failed\n");
-		return rc;
+		return rc ?: -EINVAL;
 	}
 
 	/* Handle previous output */
-- 
2.53.0

Re: [PATCH net] sfc: fix error code in efx_devlink_info_running_versions()

Posted by Edward Cree 1 month, 3 weeks ago

On 25/04/2026 10:09, Dan Carpenter wrote:
> Return -EINVAL if efx_mcdi_rpc() doesn't return enough space.
> 
> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
>  drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
> index d842c60dfc10..45f412bb9b5d 100644
> --- a/drivers/net/ethernet/sfc/efx_devlink.c
> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
> @@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,
>  	if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) {
>  		netif_err(efx, drv, efx->net_dev,
>  			  "mcdi MC_CMD_GET_VERSION failed\n");
> -		return rc;
> +		return rc ?: -EINVAL;
>  	}
>  
>  	/* Handle previous output */

Usual practice in sfc is to use -EIO for 'MC response was too short'; it
 signifies misbehaviour from the hardware, not any invalid input argument
 as -EINVAL would suggest.
Other than that, looks fine.

-ed

Re: [PATCH net] sfc: fix error code in efx_devlink_info_running_versions()

Posted by Dan Carpenter 1 month, 3 weeks ago

On Tue, Apr 28, 2026 at 02:36:55PM +0100, Edward Cree wrote:
> On 25/04/2026 10:09, Dan Carpenter wrote:
> > Return -EINVAL if efx_mcdi_rpc() doesn't return enough space.
> > 
> > Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > ---
> >  drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
> > index d842c60dfc10..45f412bb9b5d 100644
> > --- a/drivers/net/ethernet/sfc/efx_devlink.c
> > +++ b/drivers/net/ethernet/sfc/efx_devlink.c
> > @@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,
> >  	if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) {
> >  		netif_err(efx, drv, efx->net_dev,
> >  			  "mcdi MC_CMD_GET_VERSION failed\n");
> > -		return rc;
> > +		return rc ?: -EINVAL;
> >  	}
> >  
> >  	/* Handle previous output */
> 
> Usual practice in sfc is to use -EIO for 'MC response was too short'; it
>  signifies misbehaviour from the hardware, not any invalid input argument
>  as -EINVAL would suggest.
> Other than that, looks fine.

Sure, I'll send a v2.

regards,
dan carpenter

Re: [PATCH net] sfc: fix error code in efx_devlink_info_running_versions()

Posted by Simon Horman 1 month, 3 weeks ago

On Sat, Apr 25, 2026 at 12:09:32PM +0300, Dan Carpenter wrote:
> Return -EINVAL if efx_mcdi_rpc() doesn't return enough space.
> 
> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>