Hi all,
Today's linux-next merge of the jc_docs tree got a conflict in:
scripts/checkpatch.pl
between commit:
d1db4118489ff ("checkpatch: add support for Assisted-by tag")
from the mm-nomm-stable tree and commit:
8545d9bc4bd08 ("scripts/checkpatch: add Assisted-by: tag validation")
from the jc_docs tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
(The mm version does seem to misidentify as a signoff)
diff --cc scripts/checkpatch.pl
index 60fd2ee2d0e58,b8d961d77ff4e..0000000000000
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@@ -3106,11 -3106,11 +3106,11 @@@ sub process
}
}
-# Assisted-by: uses format AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2] instead of email
+ # Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
- if ($sign_off =~ /^Assisted-by:/i) {
- if ($email !~ /^\S+:\S+/) {
- WARN("BAD_SIGN_OFF",
- "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
+ if ($sign_off =~ /^assisted-by:$/i) {
+ if ($email !~ /^[^:]+:\S+(\s+\S+)*$/) {
+ WARN("BAD_ASSISTED_BY",
+ "Assisted-by: should use format: 'Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]'\n" . $herecurr);
}
next;
}
Mark Brown <broonie@kernel.org> writes:
> Hi all,
>
> Today's linux-next merge of the jc_docs tree got a conflict in:
>
> scripts/checkpatch.pl
>
> between commit:
>
> d1db4118489ff ("checkpatch: add support for Assisted-by tag")
>
> from the mm-nomm-stable tree and commit:
>
> 8545d9bc4bd08 ("scripts/checkpatch: add Assisted-by: tag validation")
>
> from the jc_docs tree.
Ah...I didn't realize that somebody had already addressed that problem.
Certainly we don't need two of them. I can drop mine.
Thanks,
jon
© 2016 - 2026 Red Hat, Inc.