[PATCH] staging: rtl8723bs: rename camelCase variable

Bhavya Gupta posted 1 patch 4 days, 2 hours ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[PATCH] staging: rtl8723bs: rename camelCase variable
Posted by Bhavya Gupta 4 days, 2 hours ago
Rename the "pIE" variable to "ie" to comply with the linux kernel coding
style.

This fixes the following checkpatch.pl warnings:
	CHECK: Avoid CamelCase: <pIE>

Signed-off-by: Bhavya Gupta <anim8tor.ing@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 4cdcdddf6b33..4b4012411011 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1364,20 +1364,20 @@ static void update_bcn_erpinfo_ie(struct adapter *padapter)
 		       &len,
 		       (pnetwork->ie_length - _BEACON_IE_OFFSET_));
 	if (p && len > 0) {
-		struct ndis_80211_var_ie *pIE = (struct ndis_80211_var_ie *)p;
+		struct ndis_80211_var_ie *ie = (struct ndis_80211_var_ie *)p;
 
 		if (pmlmepriv->num_sta_non_erp == 1)
-			pIE->data[0] |= RTW_ERP_INFO_NON_ERP_PRESENT | RTW_ERP_INFO_USE_PROTECTION;
+			ie->data[0] |= RTW_ERP_INFO_NON_ERP_PRESENT | RTW_ERP_INFO_USE_PROTECTION;
 		else
-			pIE->data[0] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |
+			ie->data[0] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |
 					  RTW_ERP_INFO_USE_PROTECTION);
 
 		if (pmlmepriv->num_sta_no_short_preamble > 0)
-			pIE->data[0] |= RTW_ERP_INFO_BARKER_PREAMBLE_MODE;
+			ie->data[0] |= RTW_ERP_INFO_BARKER_PREAMBLE_MODE;
 		else
-			pIE->data[0] &= ~(RTW_ERP_INFO_BARKER_PREAMBLE_MODE);
+			ie->data[0] &= ~(RTW_ERP_INFO_BARKER_PREAMBLE_MODE);
 
-		ERP_IE_handler(padapter, pIE);
+		ERP_IE_handler(padapter, ie);
 	}
 }
 
-- 
2.53.0
Re: [PATCH] staging: rtl8723bs: rename camelCase variable
Posted by Greg KH 2 days, 2 hours ago
On Sun, Mar 29, 2026 at 01:37:29PM +0530, Bhavya Gupta wrote:
> Rename the "pIE" variable to "ie" to comply with the linux kernel coding
> style.
> 
> This fixes the following checkpatch.pl warnings:
> 	CHECK: Avoid CamelCase: <pIE>
> 
> Signed-off-by: Bhavya Gupta <anim8tor.ing@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 4cdcdddf6b33..4b4012411011 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -1364,20 +1364,20 @@ static void update_bcn_erpinfo_ie(struct adapter *padapter)
>  		       &len,
>  		       (pnetwork->ie_length - _BEACON_IE_OFFSET_));
>  	if (p && len > 0) {
> -		struct ndis_80211_var_ie *pIE = (struct ndis_80211_var_ie *)p;
> +		struct ndis_80211_var_ie *ie = (struct ndis_80211_var_ie *)p;
>  
>  		if (pmlmepriv->num_sta_non_erp == 1)
> -			pIE->data[0] |= RTW_ERP_INFO_NON_ERP_PRESENT | RTW_ERP_INFO_USE_PROTECTION;
> +			ie->data[0] |= RTW_ERP_INFO_NON_ERP_PRESENT | RTW_ERP_INFO_USE_PROTECTION;
>  		else
> -			pIE->data[0] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |
> +			ie->data[0] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |
>  					  RTW_ERP_INFO_USE_PROTECTION);
>  
>  		if (pmlmepriv->num_sta_no_short_preamble > 0)
> -			pIE->data[0] |= RTW_ERP_INFO_BARKER_PREAMBLE_MODE;
> +			ie->data[0] |= RTW_ERP_INFO_BARKER_PREAMBLE_MODE;
>  		else
> -			pIE->data[0] &= ~(RTW_ERP_INFO_BARKER_PREAMBLE_MODE);
> +			ie->data[0] &= ~(RTW_ERP_INFO_BARKER_PREAMBLE_MODE);
>  
> -		ERP_IE_handler(padapter, pIE);
> +		ERP_IE_handler(padapter, ie);
>  	}
>  }
>  
> -- 
> 2.53.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did not apply to any known trees that Greg is in control
  of.  Possibly this is because you made it against Linus's tree, not
  the linux-next tree, which is where all of the development for the
  next version of the kernel is at.  Please refresh your patch against
  the linux-next tree, or even better yet, the development tree
  specified in the MAINTAINERS file for the subsystem you are submitting
  a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
Re: [PATCH] staging: rtl8723bs: rename camelCase variable
Posted by Ethan Tidmore 3 days, 11 hours ago
On Sun Mar 29, 2026 at 3:07 AM CDT, Bhavya Gupta wrote:
> Rename the "pIE" variable to "ie" to comply with the linux kernel coding
> style.
>
> This fixes the following checkpatch.pl warnings:
> 	CHECK: Avoid CamelCase: <pIE>
>
> Signed-off-by: Bhavya Gupta <anim8tor.ing@gmail.com>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET