[PATCH] vhost_task_create: kill unnecessary .exit_signal initialization

Oleg Nesterov posted 1 patch 1 week, 5 days ago
kernel/vhost_task.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] vhost_task_create: kill unnecessary .exit_signal initialization
Posted by Oleg Nesterov 1 week, 5 days ago
The only reason for this janitorial change is that this initialization
adds unnecessary noise to "git grep exit_signal".

args.exit_signal has no effect with CLONE_THREAD, not to mention it is
zero-initialized by the compiler anyway.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 kernel/vhost_task.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/vhost_task.c b/kernel/vhost_task.c
index 3f1ed7ef0582..3717885a5992 100644
--- a/kernel/vhost_task.c
+++ b/kernel/vhost_task.c
@@ -123,7 +123,6 @@ struct vhost_task *vhost_task_create(bool (*fn)(void *),
 	struct kernel_clone_args args = {
 		.flags		= CLONE_FS | CLONE_UNTRACED | CLONE_VM |
 				  CLONE_THREAD | CLONE_SIGHAND,
-		.exit_signal	= 0,
 		.fn		= vhost_task_fn,
 		.name		= name,
 		.user_worker	= 1,
-- 
2.52.0
Re: [PATCH] vhost_task_create: kill unnecessary .exit_signal initialization
Posted by Jason Wang 1 week, 4 days ago
On Sun, Mar 22, 2026 at 11:20 PM Oleg Nesterov <oleg@redhat.com> wrote:
>
> The only reason for this janitorial change is that this initialization
> adds unnecessary noise to "git grep exit_signal".
>
> args.exit_signal has no effect with CLONE_THREAD, not to mention it is
> zero-initialized by the compiler anyway.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
>  kernel/vhost_task.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/vhost_task.c b/kernel/vhost_task.c
> index 3f1ed7ef0582..3717885a5992 100644
> --- a/kernel/vhost_task.c
> +++ b/kernel/vhost_task.c
> @@ -123,7 +123,6 @@ struct vhost_task *vhost_task_create(bool (*fn)(void *),
>         struct kernel_clone_args args = {
>                 .flags          = CLONE_FS | CLONE_UNTRACED | CLONE_VM |
>                                   CLONE_THREAD | CLONE_SIGHAND,
> -               .exit_signal    = 0,
>                 .fn             = vhost_task_fn,
>                 .name           = name,
>                 .user_worker    = 1,
> --
> 2.52.0
>
>

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks