media: i2c: max9286: normalize return value of gpio_get

[PATCH] media: i2c: max9286: normalize return value of gpio_get

Posted by Dmitry Torokhov 1 month, 3 weeks ago

The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by max9286_gpiochip_get() is
normalized to the [0, 1] range.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/media/i2c/max9286.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index e6e214f8294b..ac0712ce1e65 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
 {
 	struct max9286_priv *priv = gpiochip_get_data(chip);
 
-	return priv->gpio_state & BIT(offset);
+	return !!(priv->gpio_state & BIT(offset));
 }
 
 static int max9286_register_gpio(struct max9286_priv *priv)
-- 
2.53.0.335.g19a08e0c02-goog


-- 
Dmitry

Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get

Posted by Linus Walleij 1 month, 3 weeks ago

On Wed, Feb 18, 2026 at 9:53 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:

> The GPIO get callback is expected to return 0 or 1 (or a negative error
> code). Ensure that the value returned by max9286_gpiochip_get() is
> normalized to the [0, 1] range.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get

Posted by Kieran Bingham 1 month, 3 weeks ago

Quoting Dmitry Torokhov (2026-02-18 20:53:48)
> The GPIO get callback is expected to return 0 or 1 (or a negative error
> code). Ensure that the value returned by max9286_gpiochip_get() is
> normalized to the [0, 1] range.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/media/i2c/max9286.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index e6e214f8294b..ac0712ce1e65 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
>  {
>         struct max9286_priv *priv = gpiochip_get_data(chip);
>  
> -       return priv->gpio_state & BIT(offset);
> +       return !!(priv->gpio_state & BIT(offset));

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

>  }
>  
>  static int max9286_register_gpio(struct max9286_priv *priv)
> -- 
> 2.53.0.335.g19a08e0c02-goog
> 
> 
> -- 
> Dmitry

Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get

Posted by Bartosz Golaszewski 1 month, 3 weeks ago

On Wed, 18 Feb 2026 21:53:48 +0100, Dmitry Torokhov
<dmitry.torokhov@gmail.com> said:
> The GPIO get callback is expected to return 0 or 1 (or a negative error
> code). Ensure that the value returned by max9286_gpiochip_get() is
> normalized to the [0, 1] range.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/media/i2c/max9286.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index e6e214f8294b..ac0712ce1e65 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
>  {
>  	struct max9286_priv *priv = gpiochip_get_data(chip);
>
> -	return priv->gpio_state & BIT(offset);
> +	return !!(priv->gpio_state & BIT(offset));
>  }
>
>  static int max9286_register_gpio(struct max9286_priv *priv)
> --
> 2.53.0.335.g19a08e0c02-goog
>
>
> --
> Dmitry
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get

Posted by Ricardo Ribalda 1 month, 3 weeks ago

On Wed, 18 Feb 2026 at 21:53, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> The GPIO get callback is expected to return 0 or 1 (or a negative error
> code). Ensure that the value returned by max9286_gpiochip_get() is
> normalized to the [0, 1] range.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/i2c/max9286.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index e6e214f8294b..ac0712ce1e65 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
>  {
>         struct max9286_priv *priv = gpiochip_get_data(chip);
>
> -       return priv->gpio_state & BIT(offset);
> +       return !!(priv->gpio_state & BIT(offset));
>  }
>
>  static int max9286_register_gpio(struct max9286_priv *priv)
> --
> 2.53.0.335.g19a08e0c02-goog
>
>
> --
> Dmitry



-- 
Ricardo Ribalda