[PATCH] ALSA: oss: delete self assignment

Dan Carpenter posted 1 patch 22 hours ago
sound/core/oss/mixer_oss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ALSA: oss: delete self assignment
Posted by Dan Carpenter 22 hours ago
No need to assign "uctl" to itself.  Delete it.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 sound/core/oss/mixer_oss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c
index 69422ab2d808..8d2d46d03301 100644
--- a/sound/core/oss/mixer_oss.c
+++ b/sound/core/oss/mixer_oss.c
@@ -792,7 +792,7 @@ static int snd_mixer_oss_get_recsrc2(struct snd_mixer_oss_file *fmixer, unsigned
 	struct snd_ctl_elem_info *uinfo __free(kfree) =
 		kzalloc(sizeof(*uinfo), GFP_KERNEL);
 	struct snd_ctl_elem_value *uctl __free(kfree) =
-		uctl = kzalloc(sizeof(*uctl), GFP_KERNEL);
+		kzalloc(sizeof(*uctl), GFP_KERNEL);
 	if (uinfo == NULL || uctl == NULL)
 		return -ENOMEM;
 	guard(rwsem_read)(&card->controls_rwsem);
-- 
2.51.0
Re: [PATCH] ALSA: oss: delete self assignment
Posted by Takashi Iwai 22 hours ago
On Fri, 06 Feb 2026 14:41:47 +0100,
Dan Carpenter wrote:
> 
> No need to assign "uctl" to itself.  Delete it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Thanks, it's a garbage at the previous fix commit 55f98ece9939 ("ALSA:
oss: Relax __free() variable declarations").  So I applied with a
Fixes tag.


Takashi