platform/x86: pcengines-apuv2: attach software node to the gpiochip

[PATCH] platform/x86: pcengines-apuv2: attach software node to the gpiochip

Posted by Dmitry Torokhov 1 month, 2 weeks ago

GPIO subsystem is switching the way it locates GPIO chip instances for
GPIO references in software nodes from matching on node names to
identity matching, which necessitates assigning firmware nodes
(software nodes) to GPIO chips.

Attach apu2_gpiochip_node to the platform device representing the GPIO
controller.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/platform/x86/pcengines-apuv2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index 3b086863c6ac..3f19589d1ba0 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -294,7 +294,8 @@ static int __init apu_board_init(void)
 	}
 
 	apu_gpio_pdev = apu_create_pdev(AMD_FCH_GPIO_DRIVER_NAME,
-					id->driver_data, sizeof(struct amd_fch_gpio_pdata), NULL);
+					id->driver_data, sizeof(struct amd_fch_gpio_pdata),
+					&apu2_gpiochip_node);
 	err = PTR_ERR_OR_ZERO(apu_gpio_pdev);
 	if (err)
 		goto err_unregister_swnodes;
-- 
2.53.0.310.g728cabbaf7-goog


-- 
Dmitry

Re: [PATCH] platform/x86: pcengines-apuv2: attach software node to the gpiochip

Posted by Ilpo Järvinen 1 month ago

On Fri, 13 Feb 2026 14:40:32 -0800, Dmitry Torokhov wrote:

> GPIO subsystem is switching the way it locates GPIO chip instances for
> GPIO references in software nodes from matching on node names to
> identity matching, which necessitates assigning firmware nodes
> (software nodes) to GPIO chips.
> 
> Attach apu2_gpiochip_node to the platform device representing the GPIO
> controller.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: pcengines-apuv2: attach software node to the gpiochip
      commit: 0e59b31dbd3bfca96567e3d22518f4b6a7051a40

--
 i.

Re: [PATCH] platform/x86: pcengines-apuv2: attach software node to the gpiochip

Posted by Bartosz Golaszewski 1 month, 2 weeks ago

On Fri, Feb 13, 2026 at 11:40 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> GPIO subsystem is switching the way it locates GPIO chip instances for
> GPIO references in software nodes from matching on node names to
> identity matching, which necessitates assigning firmware nodes
> (software nodes) to GPIO chips.
>
> Attach apu2_gpiochip_node to the platform device representing the GPIO
> controller.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/platform/x86/pcengines-apuv2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index 3b086863c6ac..3f19589d1ba0 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -294,7 +294,8 @@ static int __init apu_board_init(void)
>         }
>
>         apu_gpio_pdev = apu_create_pdev(AMD_FCH_GPIO_DRIVER_NAME,
> -                                       id->driver_data, sizeof(struct amd_fch_gpio_pdata), NULL);
> +                                       id->driver_data, sizeof(struct amd_fch_gpio_pdata),
> +                                       &apu2_gpiochip_node);
>         err = PTR_ERR_OR_ZERO(apu_gpio_pdev);
>         if (err)
>                 goto err_unregister_swnodes;
> --

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>