xfs: fix memory leak in xfs_growfs_check_rtgeom()

[PATCH next] xfs: fix memory leak in xfs_growfs_check_rtgeom()

Posted by Dan Carpenter 1 month, 2 weeks ago

Free the "nmp" allocation before returning -EINVAL.

Fixes: dc68c0f60169 ("xfs: fix the zoned RT growfs check for zone alignment")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 fs/xfs/xfs_rtalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index e063f4f2f2e6..167298ad88dd 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -1265,7 +1265,7 @@ xfs_growfs_check_rtgeom(
 		uint32_t	rem;
 
 		if (rextsize != 1)
-			return -EINVAL;
+			goto out_inval;
 		div_u64_rem(nmp->m_sb.sb_rblocks, gblocks, &rem);
 		if (rem) {
 			xfs_warn(mp,
-- 
2.51.0

Re: [PATCH next] xfs: fix memory leak in xfs_growfs_check_rtgeom()

Posted by Carlos Maiolino 4 weeks, 1 day ago

On Fri, 19 Dec 2025 13:33:50 +0300, Dan Carpenter wrote:
> Free the "nmp" allocation before returning -EINVAL.
> 
> 

Applied to for-next, thanks!

[1/1] xfs: fix memory leak in xfs_growfs_check_rtgeom()
      commit: 8dad31f85c7b91fd8bdbc6d0f27abc53bd8b1ffe

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>

Re: [PATCH next] xfs: fix memory leak in xfs_growfs_check_rtgeom()

Posted by Christoph Hellwig 1 month, 2 weeks ago

On Fri, Dec 19, 2025 at 01:33:50PM +0300, Dan Carpenter wrote:
> Free the "nmp" allocation before returning -EINVAL.
> 
> Fixes: dc68c0f60169 ("xfs: fix the zoned RT growfs check for zone alignment")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>