[PATCH next] drm/xe/xe_sriov_vfio: Fix return value in xe_sriov_vfio_migration_supported()

Dan Carpenter posted 1 patch 2 months ago
drivers/gpu/drm/xe/xe_sriov_vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH next] drm/xe/xe_sriov_vfio: Fix return value in xe_sriov_vfio_migration_supported()
Posted by Dan Carpenter 2 months ago
The xe_sriov_vfio_migration_supported() function is type bool so
returning -EPERM means returning true.  Return false instead.

Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/gpu/drm/xe/xe_sriov_vfio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_sriov_vfio.c b/drivers/gpu/drm/xe/xe_sriov_vfio.c
index e9a7615bb5c5..3da81af97b8b 100644
--- a/drivers/gpu/drm/xe/xe_sriov_vfio.c
+++ b/drivers/gpu/drm/xe/xe_sriov_vfio.c
@@ -21,7 +21,7 @@ EXPORT_SYMBOL_FOR_MODULES(xe_sriov_vfio_get_pf, "xe-vfio-pci");
 bool xe_sriov_vfio_migration_supported(struct xe_device *xe)
 {
 	if (!IS_SRIOV_PF(xe))
-		return -EPERM;
+		return false;
 
 	return xe_sriov_pf_migration_supported(xe);
 }
-- 
2.51.0
Re: [PATCH next] drm/xe/xe_sriov_vfio: Fix return value in xe_sriov_vfio_migration_supported()
Posted by Michal Wajdeczko 2 months ago

On 12/5/2025 12:39 PM, Dan Carpenter wrote:
> The xe_sriov_vfio_migration_supported() function is type bool so
> returning -EPERM means returning true.  Return false instead.
> 
> Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_sriov_vfio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sriov_vfio.c b/drivers/gpu/drm/xe/xe_sriov_vfio.c
> index e9a7615bb5c5..3da81af97b8b 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_vfio.c
> +++ b/drivers/gpu/drm/xe/xe_sriov_vfio.c
> @@ -21,7 +21,7 @@ EXPORT_SYMBOL_FOR_MODULES(xe_sriov_vfio_get_pf, "xe-vfio-pci");
>  bool xe_sriov_vfio_migration_supported(struct xe_device *xe)
>  {
>  	if (!IS_SRIOV_PF(xe))
> -		return -EPERM;
> +		return false;
>  
>  	return xe_sriov_pf_migration_supported(xe);
>  }