[v3] Checkpatch cleanup patches

[PATCH v3 0/2] Checkpatch cleanup patches

Posted by Bryant Boatright 4 months ago

Correct camel case names reported by checkpatch.

These patches are not required to be applied in any order.

Changes in v3:
   1. Patch 1: Updated parse_res to parse_result for clearer purpose per
      feedback from gregkh@linuxfoundation.org.
   2. Patch 1: Change definition of parse_result to multi-line definition per
      feed feedback from gregkh@linuxfoundation.org.
   3. Patch 2: Fix typo in commit message introduced in v2 per feedback from
      gregkh@linuxfoundation.org.
   4. Remove patch 2 (from v2) as name change was not needed per feedback from
      gregkh@linuxfoundation.org.
   5. Add changelog for patchset to cover letter per feedback from
      gregkh@linuxfoundation.org.

Changes in v2:
   1. Patch 1: Make enumeration constant names all upper case per feedback from
   straube.linux@gmail.com.

Bryant Boatright (2):
  staging: rtl8723bs: Rename camel case enumeration
  staging: rtl8723bs: Rename camel case variable

 .../staging/rtl8723bs/core/rtw_ieee80211.c    | 26 +++++++++----------
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  2 +-
 drivers/staging/rtl8723bs/include/ieee80211.h | 12 ++++++---
 3 files changed, 22 insertions(+), 18 deletions(-)

-- 
2.43.0

Re: [PATCH v3 0/2] Checkpatch cleanup patches

Posted by Greg Kroah-Hartman 3 months, 3 weeks ago

On Thu, Dec 04, 2025 at 11:44:19AM +0000, Bryant Boatright wrote:
> Correct camel case names reported by checkpatch.
> 
> These patches are not required to be applied in any order.
> 
> Changes in v3:
>    1. Patch 1: Updated parse_res to parse_result for clearer purpose per
>       feedback from gregkh@linuxfoundation.org.
>    2. Patch 1: Change definition of parse_result to multi-line definition per
>       feed feedback from gregkh@linuxfoundation.org.
>    3. Patch 2: Fix typo in commit message introduced in v2 per feedback from
>       gregkh@linuxfoundation.org.
>    4. Remove patch 2 (from v2) as name change was not needed per feedback from
>       gregkh@linuxfoundation.org.
>    5. Add changelog for patchset to cover letter per feedback from
>       gregkh@linuxfoundation.org.
> 
> Changes in v2:
>    1. Patch 1: Make enumeration constant names all upper case per feedback from
>    straube.linux@gmail.com.
> 
> Bryant Boatright (2):
>   staging: rtl8723bs: Rename camel case enumeration
>   staging: rtl8723bs: Rename camel case variable
> 
>  .../staging/rtl8723bs/core/rtw_ieee80211.c    | 26 +++++++++----------
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  2 +-
>  drivers/staging/rtl8723bs/include/ieee80211.h | 12 ++++++---
>  3 files changed, 22 insertions(+), 18 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> 

These did not come through as properly linked together, how did you send
them?  Can you use something like 'b4' or 'git send-email' to send them
as a patch series, and not as unconnected emails?

thanks,

greg k-h

Re: [PATCH v3 0/2] Checkpatch cleanup patches

Posted by Bryant Boatright 1 month, 3 weeks ago

On Wed, Dec 17, 2025 at 02:03:25PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Dec 04, 2025 at 11:44:19AM +0000, Bryant Boatright wrote:
> > Correct camel case names reported by checkpatch.
> >
> > These patches are not required to be applied in any order.
> >
> > Changes in v3:
> >    1. Patch 1: Updated parse_res to parse_result for clearer purpose per
> >       feedback from gregkh@linuxfoundation.org.
> >    2. Patch 1: Change definition of parse_result to multi-line definition per
> >       feed feedback from gregkh@linuxfoundation.org.
> >    3. Patch 2: Fix typo in commit message introduced in v2 per feedback from
> >       gregkh@linuxfoundation.org.
> >    4. Remove patch 2 (from v2) as name change was not needed per feedback from
> >       gregkh@linuxfoundation.org.
> >    5. Add changelog for patchset to cover letter per feedback from
> >       gregkh@linuxfoundation.org.
> >
> > Changes in v2:
> >    1. Patch 1: Make enumeration constant names all upper case per feedback from
> >    straube.linux@gmail.com.
> >
> > Bryant Boatright (2):
> >   staging: rtl8723bs: Rename camel case enumeration
> >   staging: rtl8723bs: Rename camel case variable
> >
> >  .../staging/rtl8723bs/core/rtw_ieee80211.c    | 26 +++++++++----------
> >  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  2 +-
> >  drivers/staging/rtl8723bs/include/ieee80211.h | 12 ++++++---
> >  3 files changed, 22 insertions(+), 18 deletions(-)
> >
> > --
> > 2.43.0
> >
> >
> >
> 
> These did not come through as properly linked together, how did you send
> them?  Can you use something like 'b4' or 'git send-email' to send them
> as a patch series, and not as unconnected emails?
> 
> thanks,
> 
> greg k-h
> 

Sorry for the delayed response. Yes, I can do that - apologies for not catching
that on this version.

Would you want that sent as a V4 patch, or just resend this series but correctly
linked?

Re: [PATCH v3 0/2] Checkpatch cleanup patches

Posted by Greg Kroah-Hartman 1 month, 3 weeks ago

On Mon, Feb 16, 2026 at 08:03:47AM +0000, Bryant Boatright wrote:
> On Wed, Dec 17, 2025 at 02:03:25PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Dec 04, 2025 at 11:44:19AM +0000, Bryant Boatright wrote:
> > > Correct camel case names reported by checkpatch.
> > >
> > > These patches are not required to be applied in any order.
> > >
> > > Changes in v3:
> > >    1. Patch 1: Updated parse_res to parse_result for clearer purpose per
> > >       feedback from gregkh@linuxfoundation.org.
> > >    2. Patch 1: Change definition of parse_result to multi-line definition per
> > >       feed feedback from gregkh@linuxfoundation.org.
> > >    3. Patch 2: Fix typo in commit message introduced in v2 per feedback from
> > >       gregkh@linuxfoundation.org.
> > >    4. Remove patch 2 (from v2) as name change was not needed per feedback from
> > >       gregkh@linuxfoundation.org.
> > >    5. Add changelog for patchset to cover letter per feedback from
> > >       gregkh@linuxfoundation.org.
> > >
> > > Changes in v2:
> > >    1. Patch 1: Make enumeration constant names all upper case per feedback from
> > >    straube.linux@gmail.com.
> > >
> > > Bryant Boatright (2):
> > >   staging: rtl8723bs: Rename camel case enumeration
> > >   staging: rtl8723bs: Rename camel case variable
> > >
> > >  .../staging/rtl8723bs/core/rtw_ieee80211.c    | 26 +++++++++----------
> > >  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  2 +-
> > >  drivers/staging/rtl8723bs/include/ieee80211.h | 12 ++++++---
> > >  3 files changed, 22 insertions(+), 18 deletions(-)
> > >
> > > --
> > > 2.43.0
> > >
> > >
> > >
> > 
> > These did not come through as properly linked together, how did you send
> > them?  Can you use something like 'b4' or 'git send-email' to send them
> > as a patch series, and not as unconnected emails?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> Sorry for the delayed response. Yes, I can do that - apologies for not catching
> that on this version.
> 
> Would you want that sent as a V4 patch, or just resend this series but correctly
> linked?

V4 series please.

thanks,

greg k-h