iommufd: Fix error code in iommu_device_register_bus()

[PATCH next] iommufd: Fix error code in iommu_device_register_bus()

Posted by Dan Carpenter 2 months, 2 weeks ago

This error path accidentally returns success.  Return
PTR_ERR(iommu->fwnode) instead.

Fixes: 885add2e6be6 ("iommufd: Register iommufd mock devices with fwspec")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/iommu/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index ddf398d8bcf9..59244c744eab 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -330,7 +330,7 @@ int iommu_device_register_bus(struct iommu_device *iommu,
 	iommu->fwnode = fwnode_create_software_node(NULL, NULL);
 	if (IS_ERR(iommu->fwnode)) {
 		bus_unregister_notifier(bus, nb);
-		return err;
+		return PTR_ERR(iommu->fwnode);
 	}
 
 	spin_lock(&iommu_device_lock);
-- 
2.51.0

Re: [PATCH next] iommufd: Fix error code in iommu_device_register_bus()

Posted by Jason Gunthorpe 2 months, 2 weeks ago

On Tue, Sep 30, 2025 at 03:25:52PM +0300, Dan Carpenter wrote:
>  	iommu->fwnode = fwnode_create_software_node(NULL, NULL);
>  	if (IS_ERR(iommu->fwnode)) {
>  		bus_unregister_notifier(bus, nb);
> -		return err;
> +		return PTR_ERR(iommu->fwnode);
>  	}

Thanks Dan I fixed the commit

Jason