mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe

[PATCH next] mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe

Posted by Dan Carpenter 2 months, 2 weeks ago

The dma_alloc_noncoherent() function doesn't return error pointers, it
returns NULL on error.  Fix the error checking to match.

Fixes: 3148d0e5b1c5 ("mtd: nand: realtek-ecc: Add Realtek external ECC engine support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/mtd/nand/ecc-realtek.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/ecc-realtek.c b/drivers/mtd/nand/ecc-realtek.c
index 7d718934c909..7c275f1eb4a7 100644
--- a/drivers/mtd/nand/ecc-realtek.c
+++ b/drivers/mtd/nand/ecc-realtek.c
@@ -418,8 +418,8 @@ static int rtl_ecc_probe(struct platform_device *pdev)
 
 	rtlc->buf = dma_alloc_noncoherent(dev, RTL_ECC_DMA_SIZE, &rtlc->buf_dma,
 					  DMA_BIDIRECTIONAL, GFP_KERNEL);
-	if (IS_ERR(rtlc->buf))
-		return PTR_ERR(rtlc->buf);
+	if (!rtlc->buf)
+		return -ENOMEM;
 
 	rtlc->dev = dev;
 	rtlc->engine.dev = dev;
-- 
2.51.0

Re: [PATCH next] mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe

Posted by Miquel Raynal 1 month, 3 weeks ago

On Fri, 03 Oct 2025 12:30:10 +0300, Dan Carpenter wrote:
> The dma_alloc_noncoherent() function doesn't return error pointers, it
> returns NULL on error.  Fix the error checking to match.
> 
> 

Applied to mtd/fixes, thanks!

[1/1] mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe
      commit: 9225f02ff201837e1443076f37a3c008140d1835

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl

Re: [PATCH next] mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe

Posted by Geert Uytterhoeven 2 months, 1 week ago

On Fri, 3 Oct 2025 at 11:30, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> The dma_alloc_noncoherent() function doesn't return error pointers, it
> returns NULL on error.  Fix the error checking to match.
>
> Fixes: 3148d0e5b1c5 ("mtd: nand: realtek-ecc: Add Realtek external ECC engine support")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

AW: [PATCH next] mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe

Posted by markus.stockhausen@gmx.de 2 months, 2 weeks ago

> Von: Dan Carpenter <dan.carpenter@linaro.org> 
> Gesendet: Freitag, 3. Oktober 2025 11:30
>
> The dma_alloc_noncoherent() function doesn't return error pointers, it
> returns NULL on error.  Fix the error checking to match.

Hi Dan,

thanks for the quick fix.

Markus