EDAC/versalnet: Fix error code in probe()

[PATCH next] EDAC/versalnet: Fix error code in probe()

Posted by Dan Carpenter 3 months ago

This code returns success if devm_kzalloc() fails.  Return -ENOMEM
instead.

Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/edac/versalnet_edac.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
index 66714fffa591..7c5db8bf0595 100644
--- a/drivers/edac/versalnet_edac.c
+++ b/drivers/edac/versalnet_edac.c
@@ -888,8 +888,10 @@ static int mc_probe(struct platform_device *pdev)
 	}
 
 	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
-	if (!priv)
+	if (!priv) {
+		rc = -ENOMEM;
 		goto err_alloc;
+	}
 
 	amd_rpmsg_id_table[0].driver_data = (kernel_ulong_t)priv;
 
-- 
2.51.0

Re: [PATCH next] EDAC/versalnet: Fix error code in probe()

Posted by Borislav Petkov 3 months ago

On Thu, Sep 18, 2025 at 09:57:47AM +0300, Dan Carpenter wrote:
> This code returns success if devm_kzalloc() fails.  Return -ENOMEM
> instead.
> 
> Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/edac/versalnet_edac.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
> index 66714fffa591..7c5db8bf0595 100644
> --- a/drivers/edac/versalnet_edac.c
> +++ b/drivers/edac/versalnet_edac.c
> @@ -888,8 +888,10 @@ static int mc_probe(struct platform_device *pdev)
>  	}
>  
>  	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> -	if (!priv)
> +	if (!priv) {
> +		rc = -ENOMEM;
>  		goto err_alloc;
> +	}
>  
>  	amd_rpmsg_id_table[0].driver_data = (kernel_ulong_t)priv;
>  
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette