[PATCH next] spi: amlogic: Fix some error checking in aml_sfc_dma_buffer_setup()

Dan Carpenter posted 1 patch 2 weeks, 3 days ago
drivers/spi/spi-amlogic-spifc-a4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH next] spi: amlogic: Fix some error checking in aml_sfc_dma_buffer_setup()
Posted by Dan Carpenter 2 weeks, 3 days ago
There was supposed to be a "ret = " assignment here but it was
accidentally left off so the error checking doesn't work.

Fixes: 4670db6f32e9 ("spi: amlogic: add driver for Amlogic SPI Flash Controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/spi/spi-amlogic-spifc-a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-amlogic-spifc-a4.c b/drivers/spi/spi-amlogic-spifc-a4.c
index 4ca8e82fdc67..4338d00e56a6 100644
--- a/drivers/spi/spi-amlogic-spifc-a4.c
+++ b/drivers/spi/spi-amlogic-spifc-a4.c
@@ -420,7 +420,7 @@ static int aml_sfc_dma_buffer_setup(struct aml_sfc *sfc, void *databuf,
 		goto out_map_data;
 
 	cmd = CMD_DATA_ADDRH(sfc->daddr);
-	regmap_write(sfc->regmap_base, SFC_CMD, cmd);
+	ret = regmap_write(sfc->regmap_base, SFC_CMD, cmd);
 	if (ret)
 		goto out_map_data;
 
-- 
2.51.0
Re: [PATCH next] spi: amlogic: Fix some error checking in aml_sfc_dma_buffer_setup()
Posted by Dan Carpenter 2 weeks, 3 days ago
On Mon, Sep 15, 2025 at 08:49:59AM +0300, Dan Carpenter wrote:
> There was supposed to be a "ret = " assignment here but it was
> accidentally left off so the error checking doesn't work.
> 
> Fixes: 4670db6f32e9 ("spi: amlogic: add driver for Amlogic SPI Flash Controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Sorry, I should have checked lore before I sent this.  It's already been
patched.

regards,
dan carpenter