ALSA: rme32: Fix serialization in snd_rme32_capture_adat_open()

[PATCH next] ALSA: rme32: Fix serialization in snd_rme32_capture_adat_open()

Posted by Dan Carpenter 1 month ago

We accidentally deleted the wrong line of code when we did the
conversion to guard() locks.  If the rme32->capture_substream has
already been set we should return -EBUSY.

Fixes: 8bb75ae244c5 ("ALSA: rme32: Use guard() for spin locks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 sound/pci/rme32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c
index 123dddcb6972..ca9bbf554650 100644
--- a/sound/pci/rme32.c
+++ b/sound/pci/rme32.c
@@ -936,7 +936,7 @@ snd_rme32_capture_adat_open(struct snd_pcm_substream *substream)
         
 	scoped_guard(spinlock_irq, &rme32->lock) {
 		if (rme32->capture_substream != NULL)
-			spin_unlock_irq(&rme32->lock);
+			return -EBUSY;
 		rme32->capture_substream = substream;
 	}
 
-- 
2.47.2

Re: [PATCH next] ALSA: rme32: Fix serialization in snd_rme32_capture_adat_open()

Posted by Takashi Iwai 1 month ago

On Wed, 03 Sep 2025 07:52:24 +0200,
Dan Carpenter wrote:
> 
> We accidentally deleted the wrong line of code when we did the
> conversion to guard() locks.  If the rme32->capture_substream has
> already been set we should return -EBUSY.
> 
> Fixes: 8bb75ae244c5 ("ALSA: rme32: Use guard() for spin locks")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Thanks, applied now.


Takashi