Use standard string choices helper str_yes_no() to simplify
arguments of dev_info() in enic_get_vnic_config().
Avoid hardcoded multiple use of same string constants by using
helper function achieving the same functionality.

Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
---
 drivers/net/ethernet/cisco/enic/enic_res.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_res.c b/drivers/net/ethernet/cisco/enic/enic_res.c
index bbd3143ed73e..a09625d47edd 100644
--- a/drivers/net/ethernet/cisco/enic/enic_res.c
+++ b/drivers/net/ethernet/cisco/enic/enic_res.c
@@ -95,11 +95,11 @@ int enic_get_vnic_config(struct enic *enic)
 	dev_info(enic_get_dev(enic), "vNIC csum tx/rx %s/%s "
 		"tso/lro %s/%s rss %s intr mode %s type %s timer %d usec "
 		"loopback tag 0x%04x\n",
-		ENIC_SETTING(enic, TXCSUM) ? "yes" : "no",
-		ENIC_SETTING(enic, RXCSUM) ? "yes" : "no",
-		ENIC_SETTING(enic, TSO) ? "yes" : "no",
-		ENIC_SETTING(enic, LRO) ? "yes" : "no",
-		ENIC_SETTING(enic, RSS) ? "yes" : "no",
+		str_yes_no(ENIC_SETTING(enic, TXCSUM)),
+		str_yes_no(ENIC_SETTING(enic, RXCSUM)),
+		str_yes_no(ENIC_SETTING(enic, TSO)),
+		str_yes_no(ENIC_SETTING(enic, LRO)),
+		str_yes_no(ENIC_SETTING(enic, RSS)),
 		c->intr_mode == VENET_INTR_MODE_INTX ? "INTx" :
 		c->intr_mode == VENET_INTR_MODE_MSI ? "MSI" :
 		c->intr_mode == VENET_INTR_MODE_ANY ? "any" :
-- 
2.34.1

On Mon, 11 Aug 2025 00:59:25 +0530 Akhilesh Patil wrote:
> Use standard string choices helper str_yes_no() to simplify
> arguments of dev_info() in enic_get_vnic_config().
> Avoid hardcoded multiple use of same string constants by using
> helper function achieving the same functionality.

This is unnecessary noise..
-- 
pw-bot: reject