[PATCH] net: wireless: rtw8852bt: Use standard helper for string choice

Akhilesh Patil posted 1 patch 1 month, 3 weeks ago
drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] net: wireless: rtw8852bt: Use standard helper for string choice
Posted by Akhilesh Patil 1 month, 3 weeks ago
Use standard helper str_on_off() defined at string_choices.h in
_dpk_information() to improve code reusability. Reduce hardcoding
of repeated use of the same strings to save code space.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202507282341.drTGfLWA-lkp@intel.com/
Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
---
 drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c b/drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c
index d0e299803225..b01f921b4224 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c
@@ -1883,8 +1883,8 @@ static void _dpk_information(struct rtw89_dev *rtwdev, enum rtw89_phy_idx phy,
 	rtw89_debug(rtwdev, RTW89_DBG_RFK,
 		    "[DPK] S%d[%d] (PHY%d): TSSI %s/ DBCC %s/ %s/ CH%d/ %s\n",
 		    path, dpk->cur_idx[path], phy,
-		    rtwdev->is_tssi_mode[path] ? "on" : "off",
-		    rtwdev->dbcc_en ? "on" : "off",
+		    str_on_off(rtwdev->is_tssi_mode[path]),
+		    str_on_off(rtwdev->dbcc_en),
 		    dpk->bp[path][kidx].band == 0 ? "2G" :
 		    dpk->bp[path][kidx].band == 1 ? "5G" : "6G",
 		    dpk->bp[path][kidx].ch,
-- 
2.34.1
Re: [PATCH] net: wireless: rtw8852bt: Use standard helper for string choice
Posted by Ping-Ke Shih 1 month, 3 weeks ago
Akhilesh Patil <akhilesh@ee.iitb.ac.in> wrote:

> Use standard helper str_on_off() defined at string_choices.h in
> _dpk_information() to improve code reusability. Reduce hardcoding
> of repeated use of the same strings to save code space.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202507282341.drTGfLWA-lkp@intel.com/
> Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

584615412654 wifi: rtw89: 8852bt: Use standard helper for string choice

---
https://github.com/pkshih/rtw.git