PCI: endpoint: pci-ep-msi: Fix NULL vs IS_ERR() check in pci_epf_write_msi_msg()

[PATCH next] PCI: endpoint: pci-ep-msi: Fix NULL vs IS_ERR() check in pci_epf_write_msi_msg()

Posted by Dan Carpenter 6 months, 1 week ago

The pci_epc_get() function returns error pointers.  It never returns NULL.
Update the check to match.

Fixes: 1c3b002c6bf6 ("PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/pci/endpoint/pci-ep-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/endpoint/pci-ep-msi.c b/drivers/pci/endpoint/pci-ep-msi.c
index 9ca89cbfec15..1b58357b905f 100644
--- a/drivers/pci/endpoint/pci-ep-msi.c
+++ b/drivers/pci/endpoint/pci-ep-msi.c
@@ -24,7 +24,7 @@ static void pci_epf_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
 	struct pci_epf *epf;
 
 	epc = pci_epc_get(dev_name(msi_desc_to_dev(desc)));
-	if (!epc)
+	if (IS_ERR(epc))
 		return;
 
 	epf = list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list);
-- 
2.47.2

Re: [PATCH next] PCI: endpoint: pci-ep-msi: Fix NULL vs IS_ERR() check in pci_epf_write_msi_msg()

Posted by Frank Li 6 months, 1 week ago

On Fri, Aug 01, 2025 at 04:34:45PM +0300, Dan Carpenter wrote:
> The pci_epc_get() function returns error pointers.  It never returns NULL.
> Update the check to match.
>
> Fixes: 1c3b002c6bf6 ("PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/pci/endpoint/pci-ep-msi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/pci-ep-msi.c b/drivers/pci/endpoint/pci-ep-msi.c
> index 9ca89cbfec15..1b58357b905f 100644
> --- a/drivers/pci/endpoint/pci-ep-msi.c
> +++ b/drivers/pci/endpoint/pci-ep-msi.c
> @@ -24,7 +24,7 @@ static void pci_epf_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
>  	struct pci_epf *epf;
>
>  	epc = pci_epc_get(dev_name(msi_desc_to_dev(desc)));
> -	if (!epc)
> +	if (IS_ERR(epc))
>  		return;
>
>  	epf = list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list);
> --
> 2.47.2
>

Re: [PATCH next] PCI: endpoint: pci-ep-msi: Fix NULL vs IS_ERR() check in pci_epf_write_msi_msg()

Posted by Manivannan Sadhasivam 6 months ago

On Fri, 01 Aug 2025 16:34:45 +0300, Dan Carpenter wrote:
> The pci_epc_get() function returns error pointers.  It never returns NULL.
> Update the check to match.
> 
> 

Applied, thanks!

[1/1] PCI: endpoint: pci-ep-msi: Fix NULL vs IS_ERR() check in pci_epf_write_msi_msg()
      commit: 57a75fa9d56e310e883e4377205690e88c05781b

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>