drivers/bluetooth/btintel_pcie.c | 2 -- 1 file changed, 2 deletions(-)
Drop pci_set_drvdata(pdev, NULL) in the remove function of the pci
driver since it is useless, the data is not accessible when the driver
is removed.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/bluetooth/btintel_pcie.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index e1c688dd2d45..28fa4ca3199a 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -2339,8 +2339,6 @@ static void btintel_pcie_remove(struct pci_dev *pdev)
btintel_pcie_free(data);
pci_clear_master(pdev);
-
- pci_set_drvdata(pdev, NULL);
}
#ifdef CONFIG_DEV_COREDUMP
--
2.43.0
Hi Luiz, >-----Original Message----- >From: Salah Triki <salah.triki@gmail.com> >Sent: Thursday, July 17, 2025 8:55 AM >To: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz ><luiz.dentz@gmail.com>; linux-bluetooth@vger.kernel.org; linux- >kernel@vger.kernel.org >Cc: salah.triki@gmail.com >Subject: [PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL) > >Drop pci_set_drvdata(pdev, NULL) in the remove function of the pci driver >since it is useless, the data is not accessible when the driver is removed. > >Signed-off-by: Salah Triki <salah.triki@gmail.com> Tested-by: Kiran K <kiran.k@intel.com> >--- > drivers/bluetooth/btintel_pcie.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c >index e1c688dd2d45..28fa4ca3199a 100644 >--- a/drivers/bluetooth/btintel_pcie.c >+++ b/drivers/bluetooth/btintel_pcie.c >@@ -2339,8 +2339,6 @@ static void btintel_pcie_remove(struct pci_dev >*pdev) > btintel_pcie_free(data); > > pci_clear_master(pdev); >- >- pci_set_drvdata(pdev, NULL); > } > > #ifdef CONFIG_DEV_COREDUMP >-- >2.43.0 > Thanks, Kiran
Hi Marcel, Luiz, and linux-bluetooth community, Thank you for the CI test results on my patch [PATCH] Bluetooth: btintel: Drop pci_set_drvdata(pdev, NULL). I've reviewed the automated test results and noted the failure of `TestRunner_mesh-tester`, specifically the "Mesh - Send cancel - 1" and "Mesh - Send cancel - 2" cases which timed out. I'm currently investigating why this seemingly unrelated change might be impacting the mesh tester functionality. I will work to understand the root cause and will submit a revised patch if necessary. Could you send some information about the two test cases ? Thank you for your time and review. Best regards, Salah Triki
© 2016 - 2025 Red Hat, Inc.