platform/x86/intel: power-domains: Fix error code in tpmi_init()

[PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init()

Posted by Dan Carpenter 6 months, 2 weeks ago

Return -ENOMEM instead of success if kcalloc() fails.

Fixes: e37be5d85c60 ("platform/x86/intel: power-domains: Add interface to get Linux die ID")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/platform/x86/intel/tpmi_power_domains.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/tpmi_power_domains.c b/drivers/platform/x86/intel/tpmi_power_domains.c
index 0c5c88eb7baf..9d8247bb9cfa 100644
--- a/drivers/platform/x86/intel/tpmi_power_domains.c
+++ b/drivers/platform/x86/intel/tpmi_power_domains.c
@@ -228,8 +228,10 @@ static int __init tpmi_init(void)
 
 	domain_die_map = kcalloc(size_mul(topology_max_packages(), MAX_POWER_DOMAINS),
 				 sizeof(*domain_die_map), GFP_KERNEL);
-	if (!domain_die_map)
+	if (!domain_die_map) {
+		ret = -ENOMEM;
 		goto free_domain_mask;
+	}
 
 	ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
 				"platform/x86/tpmi_power_domains:online",
-- 
2.47.2

Re: [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init()

Posted by Ilpo Järvinen 6 months, 1 week ago

On Fri, 06 Jun 2025 12:04:32 +0300, Dan Carpenter wrote:

> Return -ENOMEM instead of success if kcalloc() fails.
> 
> 

Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/intel: power-domains: Fix error code in tpmi_init()
      commit: 1d0a61940e22e165e6acc4a9c6fb26edbe69112e

--
 i.

Re: [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init()

Posted by srinivas pandruvada 6 months, 2 weeks ago

On Fri, 2025-06-06 at 12:04 +0300, Dan Carpenter wrote:
> Return -ENOMEM instead of success if kcalloc() fails.
> 
> Fixes: e37be5d85c60 ("platform/x86/intel: power-domains: Add
> interface to get Linux die ID")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by:Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>


> ---
>  drivers/platform/x86/intel/tpmi_power_domains.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/tpmi_power_domains.c
> b/drivers/platform/x86/intel/tpmi_power_domains.c
> index 0c5c88eb7baf..9d8247bb9cfa 100644
> --- a/drivers/platform/x86/intel/tpmi_power_domains.c
> +++ b/drivers/platform/x86/intel/tpmi_power_domains.c
> @@ -228,8 +228,10 @@ static int __init tpmi_init(void)
>  
>  	domain_die_map = kcalloc(size_mul(topology_max_packages(),
> MAX_POWER_DOMAINS),
>  				 sizeof(*domain_die_map),
> GFP_KERNEL);
> -	if (!domain_die_map)
> +	if (!domain_die_map) {
> +		ret = -ENOMEM;
>  		goto free_domain_mask;
> +	}
>  
>  	ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
>  				"platform/x86/tpmi_power_domains:onl
> ine",