[PATCH] dma-buf: Add forward declaration of struct seq_file in dma-fence.h

Herbert Xu posted 1 patch 8 months, 2 weeks ago
[PATCH] dma-buf: Add forward declaration of struct seq_file in dma-fence.h
Posted by Herbert Xu 8 months, 2 weeks ago
Add forward declaration of struct seq_file before using it in
function prototype.

Fixes: a25efb3863d0 ("dma-buf: add dma_fence_describe and dma_resv_describe v2")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
index e7ad819962e3..b751ae49d007 100644
--- a/include/linux/dma-fence.h
+++ b/include/linux/dma-fence.h
@@ -26,6 +26,7 @@
 struct dma_fence;
 struct dma_fence_ops;
 struct dma_fence_cb;
+struct seq_file;
 
 /**
  * struct dma_fence - software synchronization primitive
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH] dma-buf: Add forward declaration of struct seq_file in dma-fence.h
Posted by Christian König 8 months, 1 week ago
On 5/30/25 10:40, Herbert Xu wrote:
> Add forward declaration of struct seq_file before using it in
> function prototype.
> 
> Fixes: a25efb3863d0 ("dma-buf: add dma_fence_describe and dma_resv_describe v2")

I've removed this fixes tag since this is basically just a cleanup and not really a bug fix.

If compilation would have failed we would have noticed that much earlier.

Added my rb and pushed the result to drm-misc-next.

Thanks,
Christian.


> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index e7ad819962e3..b751ae49d007 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -26,6 +26,7 @@
>  struct dma_fence;
>  struct dma_fence_ops;
>  struct dma_fence_cb;
> +struct seq_file;
>  
>  /**
>   * struct dma_fence - software synchronization primitive