ACPI: APEI: EINJ: Clean up on error in einj_probe()

[PATCH next] ACPI: APEI: EINJ: Clean up on error in einj_probe()

Posted by Dan Carpenter 6 months, 3 weeks ago

Call acpi_put_table() before returning the error code.

Fixes: e54b1dc1c4f0 ("ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/acpi/apei/einj-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
index ca3484dac5c4..fea11a35eea3 100644
--- a/drivers/acpi/apei/einj-core.c
+++ b/drivers/acpi/apei/einj-core.c
@@ -766,7 +766,7 @@ static int __init einj_probe(struct faux_device *fdev)
 
 	rc = einj_get_available_error_type(&available_error_type);
 	if (rc)
-		return rc;
+		goto err_put_table;
 
 	rc = -ENOMEM;
 	einj_debug_dir = debugfs_create_dir("einj", apei_get_debugfs_dir());
-- 
2.47.2

Re: [PATCH next] ACPI: APEI: EINJ: Clean up on error in einj_probe()

Posted by Rafael J. Wysocki 6 months, 3 weeks ago

On Tue, May 27, 2025 at 7:43 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Call acpi_put_table() before returning the error code.
>
> Fixes: e54b1dc1c4f0 ("ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/acpi/apei/einj-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
> index ca3484dac5c4..fea11a35eea3 100644
> --- a/drivers/acpi/apei/einj-core.c
> +++ b/drivers/acpi/apei/einj-core.c
> @@ -766,7 +766,7 @@ static int __init einj_probe(struct faux_device *fdev)
>
>         rc = einj_get_available_error_type(&available_error_type);
>         if (rc)
> -               return rc;
> +               goto err_put_table;
>
>         rc = -ENOMEM;
>         einj_debug_dir = debugfs_create_dir("einj", apei_get_debugfs_dir());
> --

Applied, thanks!