iio: chemical: mhz19b: Fix error code in probe()

[PATCH next] iio: chemical: mhz19b: Fix error code in probe()

Posted by Dan Carpenter 7 months, 1 week ago

Return -ENOMEM if devm_iio_device_alloc() fails.  Don't return success.

Fixes: b43278d66e99 ("iio: chemical: Add support for Winsen MHZ19B CO2 sensor")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/iio/chemical/mhz19b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/chemical/mhz19b.c b/drivers/iio/chemical/mhz19b.c
index c0052ba3ac6c..3c64154918b1 100644
--- a/drivers/iio/chemical/mhz19b.c
+++ b/drivers/iio/chemical/mhz19b.c
@@ -276,7 +276,7 @@ static int mhz19b_probe(struct serdev_device *serdev)
 
 	indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
 	if (!indio_dev)
-		return ret;
+		return -ENOMEM;
 	serdev_device_set_drvdata(serdev, indio_dev);
 
 	st = iio_priv(indio_dev);
-- 
2.47.2

Re: [PATCH next] iio: chemical: mhz19b: Fix error code in probe()

Posted by Jonathan Cameron 7 months, 1 week ago

On Wed, 7 May 2025 15:59:00 +0300
Dan Carpenter <dan.carpenter@linaro.org> wrote:

> Return -ENOMEM if devm_iio_device_alloc() fails.  Don't return success.
> 
> Fixes: b43278d66e99 ("iio: chemical: Add support for Winsen MHZ19B CO2 sensor")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Applied.

Tah
> ---
>  drivers/iio/chemical/mhz19b.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/chemical/mhz19b.c b/drivers/iio/chemical/mhz19b.c
> index c0052ba3ac6c..3c64154918b1 100644
> --- a/drivers/iio/chemical/mhz19b.c
> +++ b/drivers/iio/chemical/mhz19b.c
> @@ -276,7 +276,7 @@ static int mhz19b_probe(struct serdev_device *serdev)
>  
>  	indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
>  	if (!indio_dev)
> -		return ret;
> +		return -ENOMEM;
>  	serdev_device_set_drvdata(serdev, indio_dev);
>  
>  	st = iio_priv(indio_dev);

Re: [PATCH next] iio: chemical: mhz19b: Fix error code in probe()

Posted by Gyeyoung Baek 7 months, 1 week ago

On Wed, May 7, 2025 at 9:59 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Return -ENOMEM if devm_iio_device_alloc() fails.  Don't return success.

I missed that devm_iio_device_alloc() can return NULL on failure.
Thanks for the patch!

Acked-by: Gyeyoung Baek <gye976@gmail.com>

--
Regards,
Gyeyoung

Re: [PATCH next] iio: chemical: mhz19b: Fix error code in probe()

Posted by David Lechner 7 months, 1 week ago

On 5/7/25 7:59 AM, Dan Carpenter wrote:
> Return -ENOMEM if devm_iio_device_alloc() fails.  Don't return success.
> 
> Fixes: b43278d66e99 ("iio: chemical: Add support for Winsen MHZ19B CO2 sensor")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Reviewed-by: David Lechner <dlechner@baylibre.com>