staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.

[PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.

Rujra Bhatt posted 1 patch 7 months, 1 week ago

Download mbox

drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.

Posted by Rujra Bhatt 7 months, 1 week ago

Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
---
 drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
index b326058a10c0..94bbb3b6576d 100644
--- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
+++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
@@ -479,7 +479,7 @@ static void agilent_82350b_return_to_local(struct gpib_board *board)
 
 static int agilent_82350b_allocate_private(struct gpib_board *board)
 {
-	board->private_data = kzalloc(sizeof(struct * board->private_data), GFP_KERNEL);
+	board->private_data = kzalloc(sizeof(struct agilent_82350b_priv), GFP_KERNEL);
 	if (!board->private_data)
 		return -ENOMEM;
 	return 0;
-- 
2.43.0

Re: [PATCH v2 RESEND] staging : gpib : agilent_82350b : agilent_82350b.c re-checked the sizeof structure, also checkpatch.pl has shown wrong error, hence now applied the right option and commited the changes, this will be PATCH V2. earlier have applied void pointer only so it will take only 8 bytes, and not the whole structure size.

Posted by Dan Carpenter 7 months, 1 week ago

I think you sent an incorrect patch earlier and you're trying to revert
that patch now?  We never applied the patch so there is no need.

regards,
dan carpenter

Posted by Greg KH 7 months, 1 week ago

On Wed, May 07, 2025 at 04:12:57PM +0530, Rujra Bhatt wrote:
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
> ---
>  drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Something went really wrong with your subject line :(