: staging: greybus: camera: fix alignment should match open parentheses

[PATCH] [Patch]: staging: greybus: camera: fix alignment should match open parentheses

Posted by Andreas Kleinbichler 9 months, 2 weeks ago

Correct the alignment of the parameters to match the open parenthesis.

Reported by checkpatch:

        CHECK: Alignment should match open parenthesis

Signed-off-by: Andreas Kleinbichler <andi.kleinbichler@gmail.com>
---
 drivers/staging/greybus/camera.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index ec9fddfc0b14..a1b76df39a8f 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -263,9 +263,10 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp,
-		unsigned int nstreams)
+static const int gb_camera_configure_streams_validate_response
+	(struct gb_camera *gcam,
+	 struct gb_camera_configure_streams_response *resp,
+	 unsigned int nstreams)
 {
 	unsigned int i;
 
-- 
2.43.0

Re: [PATCH] [Patch]: staging: greybus: camera: fix alignment should match open parentheses

Posted by Greg Kroah-Hartman 9 months, 2 weeks ago

On Thu, Apr 24, 2025 at 06:46:52PM +0200, Andreas Kleinbichler wrote:
> Correct the alignment of the parameters to match the open parenthesis.
> 
> Reported by checkpatch:
> 
>         CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Andreas Kleinbichler <andi.kleinbichler@gmail.com>
> ---
>  drivers/staging/greybus/camera.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index ec9fddfc0b14..a1b76df39a8f 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -263,9 +263,10 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
>   * Validate the stream configuration response verifying padding is correctly
>   * set and the returned number of streams is supported
>   */
> -static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
> -		struct gb_camera_configure_streams_response *resp,
> -		unsigned int nstreams)
> +static const int gb_camera_configure_streams_validate_response
> +	(struct gb_camera *gcam,

But that's not right either :(

There is no real "fix" possible for this warning, sorry.

greg k-h