[PATCH] power: supply: rk817: Simplify an error message

Christophe JAILLET posted 1 patch 2 years, 8 months ago
drivers/power/supply/rk817_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] power: supply: rk817: Simplify an error message
Posted by Christophe JAILLET 2 years, 8 months ago
dev_err_probe() already display the error code. There is no need to
duplicate it explicitly in the error message.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/power/supply/rk817_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
index 1a2143641e66..8328bcea1a29 100644
--- a/drivers/power/supply/rk817_charger.c
+++ b/drivers/power/supply/rk817_charger.c
@@ -1134,7 +1134,7 @@ static int rk817_charger_probe(struct platform_device *pdev)
 					    &bat_info);
 	if (ret) {
 		return dev_err_probe(dev, ret,
-				     "Unable to get battery info: %d\n", ret);
+				     "Unable to get battery info\n");
 	}
 
 	if ((bat_info->charge_full_design_uah <= 0) ||
-- 
2.34.1
Re: [PATCH] power: supply: rk817: Simplify an error message
Posted by Sebastian Reichel 2 years, 7 months ago
Hi,

On Sat, Apr 15, 2023 at 06:49:55PM +0200, Christophe JAILLET wrote:
> dev_err_probe() already display the error code. There is no need to
> duplicate it explicitly in the error message.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/rk817_charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> index 1a2143641e66..8328bcea1a29 100644
> --- a/drivers/power/supply/rk817_charger.c
> +++ b/drivers/power/supply/rk817_charger.c
> @@ -1134,7 +1134,7 @@ static int rk817_charger_probe(struct platform_device *pdev)
>  					    &bat_info);
>  	if (ret) {
>  		return dev_err_probe(dev, ret,
> -				     "Unable to get battery info: %d\n", ret);
> +				     "Unable to get battery info\n");
>  	}
>  
>  	if ((bat_info->charge_full_design_uah <= 0) ||
> -- 
> 2.34.1
>