selftests: find_symbol: Actually use load_mod() parameter

[PATCH] selftests: find_symbol: Actually use load_mod() parameter

Posted by Geert Uytterhoeven 1 year, 2 months ago

The parameter passed to load_mod() is stored in $MOD, but never used.
Obviously it was intended to be used instead of the hardcoded
"test_kallsyms_b" module name.

Fixes: 84b4a51fce4ccc66 ("selftests: add new kallsyms selftests")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 tools/testing/selftests/module/find_symbol.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/module/find_symbol.sh b/tools/testing/selftests/module/find_symbol.sh
index 140364d3c49fc912..2c56805c9b6e6ea0 100755
--- a/tools/testing/selftests/module/find_symbol.sh
+++ b/tools/testing/selftests/module/find_symbol.sh
@@ -44,10 +44,10 @@ load_mod()
 	local ARCH="$(uname -m)"
 	case "${ARCH}" in
 	x86_64)
-		perf stat $STATS $MODPROBE test_kallsyms_b
+		perf stat $STATS $MODPROBE $MOD
 		;;
 	*)
-		time $MODPROBE test_kallsyms_b
+		time $MODPROBE $MOD
 		exit 1
 		;;
 	esac
-- 
2.34.1

Re: [PATCH] selftests: find_symbol: Actually use load_mod() parameter

Posted by Luis Chamberlain 1 year, 2 months ago

On Thu, Nov 28, 2024 at 03:04:52PM +0100, Geert Uytterhoeven wrote:
> The parameter passed to load_mod() is stored in $MOD, but never used.
> Obviously it was intended to be used instead of the hardcoded
> "test_kallsyms_b" module name.
> 
> Fixes: 84b4a51fce4ccc66 ("selftests: add new kallsyms selftests")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks, I queued this up and already sent it as part of a pull request
to Linus as I head two other minor fixes as well.

  Luis