mfd: mt6370: Fix the interrupt naming typo

[PATCH] mfd: mt6370: Fix the interrupt naming typo

Posted by cy_huang@richtek.com 3 months ago

From: ChiYuan Huang <cy_huang@richtek.com>

Modify the lowercase character to uppercase.

Fixes: b2adf788e603 ("mfd: mt6370: Add MediaTek MT6370 support")
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
 drivers/mfd/mt6370.c | 2 +-
 drivers/mfd/mt6370.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/mt6370.c b/drivers/mfd/mt6370.c
index c126ccb25d66..c7c2efe3598c 100644
--- a/drivers/mfd/mt6370.c
+++ b/drivers/mfd/mt6370.c
@@ -95,7 +95,7 @@ static const struct regmap_irq mt6370_irqs[] = {
 	REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_SHORT, 8),
 	REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_STRB, 8),
 	REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_STRB, 8),
-	REGMAP_IRQ_REG_LINE(mT6370_IRQ_FLED2_STRB_TO, 8),
+	REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_STRB_TO, 8),
 	REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_STRB_TO, 8),
 	REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_TOR, 8),
 	REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_TOR, 8),
diff --git a/drivers/mfd/mt6370.h b/drivers/mfd/mt6370.h
index 094e59e4af4e..dd9ccc0a53f1 100644
--- a/drivers/mfd/mt6370.h
+++ b/drivers/mfd/mt6370.h
@@ -69,7 +69,7 @@
 #define MT6370_IRQ_FLED1_SHORT		79
 #define MT6370_IRQ_FLED2_STRB		80
 #define MT6370_IRQ_FLED1_STRB		81
-#define mT6370_IRQ_FLED2_STRB_TO	82
+#define MT6370_IRQ_FLED2_STRB_TO	82
 #define MT6370_IRQ_FLED1_STRB_TO	83
 #define MT6370_IRQ_FLED2_TOR		84
 #define MT6370_IRQ_FLED1_TOR		85
-- 
2.34.1

Re: (subset) [PATCH] mfd: mt6370: Fix the interrupt naming typo

Posted by Lee Jones 2 months, 4 weeks ago

On Wed, 09 Jul 2025 10:00:48 +0800, cy_huang@richtek.com wrote:
> Modify the lowercase character to uppercase.
> 
> 

Applied, thanks!

[1/1] mfd: mt6370: Fix the interrupt naming typo
      commit: 08f69ce8aecef8ed4048818f985b4a8a87bc283b

--
Lee Jones [李琼斯]

Re: [PATCH] mfd: mt6370: Fix the interrupt naming typo

Posted by Andy Shevchenko 3 months ago

On Wed, Jul 9, 2025 at 5:00 AM <cy_huang@richtek.com> wrote:
>
> Modify the lowercase character to uppercase.

...

> Fixes: b2adf788e603 ("mfd: mt6370: Add MediaTek MT6370 support")

Doesn't look like a real fix to me, although code looks good.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] mfd: mt6370: Fix the interrupt naming typo

Posted by ChiYuan Huang 3 months ago

On Wed, Jul 09, 2025 at 11:36:25AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 9, 2025 at 5:00 AM <cy_huang@richtek.com> wrote:
> >
> > Modify the lowercase character to uppercase.
> 
> ...
> 
> > Fixes: b2adf788e603 ("mfd: mt6370: Add MediaTek MT6370 support")
> 
> Doesn't look like a real fix to me, although code looks good.
> 
Yap, it's just typo. So should I remove the 'Fixes' tag and resend?
Or keep waiting for other's feedback?
> -- 
> With Best Regards,
> Andy Shevchenko