ata: space required after that ','

[PATCH] ata: space required after that ','

Posted by hanyu001@208suo.com 2 years, 6 months ago

Fixes the following checkpatch errors:

./drivers/ata/libata-transport.c:92: ERROR: space required after that 
',' (ctx:VxV)
./drivers/ata/libata-transport.c:92: ERROR: space required after that 
',' (ctx:VxV)
./drivers/ata/libata-transport.c:92: ERROR: space required after that 
',' (ctx:VxV)
./drivers/ata/libata-transport.c:92: ERROR: space required after that 
',' (ctx:VxV)
./drivers/ata/libata-transport.c:94: ERROR: space required after that 
',' (ctx:VxV)
./drivers/ata/libata-transport.c:94: ERROR: space required after that 
',' (ctx:VxV)
./drivers/ata/libata-transport.c:94: ERROR: space required after that 
',' (ctx:VxV)

Signed-off-by: Yu Han <	hanyu001@208suo.com>
---
  drivers/ata/libata-transport.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libata-transport.c 
b/drivers/ata/libata-transport.c
index e4fb9d1..4e87f77 100644
--- a/drivers/ata/libata-transport.c
+++ b/drivers/ata/libata-transport.c
@@ -89,9 +89,9 @@ struct ata_internal {
  /*
   * Hack to allow attributes of the same name in different objects.
   */
-#define ATA_DEVICE_ATTR(_prefix,_name,_mode,_show,_store) \
+#define ATA_DEVICE_ATTR(_prefix, _name, _mode, _show, _store) \
      struct device_attribute device_attr_##_prefix##_##_name = \
-    __ATTR(_name,_mode,_show,_store)
+    __ATTR(_name, _mode, _show, _store)

  #define ata_bitfield_name_match(title, table)            \
  static ssize_t                            \

Re: [PATCH] ata: space required after that ','

Posted by Damien Le Moal 2 years, 6 months ago

On 7/18/23 18:48, hanyu001@208suo.com wrote:
> Fixes the following checkpatch errors:

Same comment as in my previous email. What patch triggers this ?
Yes it is a bad code style and changing the code in that area will definitely
trigger warnings with checkpatch. But you are not changing anything...
So let's avoid churn please. If you actually fix something in that area, then
OK, add this syntax change as well.

> 
> ./drivers/ata/libata-transport.c:92: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:92: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:92: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:92: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:94: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:94: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:94: ERROR: space required after that 
> ',' (ctx:VxV)
> 
> Signed-off-by: Yu Han <	hanyu001@208suo.com>
> ---
>   drivers/ata/libata-transport.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-transport.c 
> b/drivers/ata/libata-transport.c
> index e4fb9d1..4e87f77 100644
> --- a/drivers/ata/libata-transport.c
> +++ b/drivers/ata/libata-transport.c
> @@ -89,9 +89,9 @@ struct ata_internal {
>   /*
>    * Hack to allow attributes of the same name in different objects.
>    */
> -#define ATA_DEVICE_ATTR(_prefix,_name,_mode,_show,_store) \
> +#define ATA_DEVICE_ATTR(_prefix, _name, _mode, _show, _store) \
>       struct device_attribute device_attr_##_prefix##_##_name = \
> -    __ATTR(_name,_mode,_show,_store)
> +    __ATTR(_name, _mode, _show, _store)
> 
>   #define ata_bitfield_name_match(title, table)            \
>   static ssize_t                            \

-- 
Damien Le Moal
Western Digital Research