[PATCH v4] spi: dt-bindings: brcm,bcm2835-aux-spi: Convert to dtschema

Karan Sanghavi posted 1 patch 1 month, 1 week ago
.../bindings/spi/brcm,bcm2835-aux-spi.txt     | 38 -------------
.../bindings/spi/brcm,bcm2835-aux-spi.yaml    | 53 +++++++++++++++++++
2 files changed, 53 insertions(+), 38 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt
create mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
[PATCH v4] spi: dt-bindings: brcm,bcm2835-aux-spi: Convert to dtschema
Posted by Karan Sanghavi 1 month, 1 week ago
Convert bcm2835-aux-spi binding to Dt schema

Changes since v3:
 - Updated the patch subject line
 - Reformatted the description to fit within 80 characters

Changes since V2:
 - Modified the Patch subject
 - Removed unnecessary description and example

Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/spi/brcm,bcm2835-aux-spi.txt     | 38 -------------
 .../bindings/spi/brcm,bcm2835-aux-spi.yaml    | 53 +++++++++++++++++++
 2 files changed, 53 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt
 create mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml

diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt
deleted file mode 100644
index d7668f41b..000000000
--- a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt
+++ /dev/null
@@ -1,38 +0,0 @@
-Broadcom BCM2835 auxiliary SPI1/2 controller
-
-The BCM2835 contains two forms of SPI master controller, one known simply as
-SPI0, and the other known as the "Universal SPI Master"; part of the
-auxiliary block. This binding applies to the SPI1/2 controller.
-
-Required properties:
-- compatible: Should be "brcm,bcm2835-aux-spi".
-- reg: Should contain register location and length for the spi block
-- interrupts: Should contain shared interrupt of the aux block
-- clocks: The clock feeding the SPI controller - needs to
-	  point to the auxiliary clock driver of the bcm2835,
-	  as this clock will enable the output gate for the specific
-	  clock.
-- cs-gpios: the cs-gpios (native cs is NOT supported)
-	    see also spi-bus.txt
-
-Example:
-
-spi1@7e215080 {
-	compatible = "brcm,bcm2835-aux-spi";
-	reg = <0x7e215080 0x40>;
-	interrupts = <1 29>;
-	clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI1>;
-	#address-cells = <1>;
-	#size-cells = <0>;
-	cs-gpios = <&gpio 18>, <&gpio 17>, <&gpio 16>;
-};
-
-spi2@7e2150c0 {
-	compatible = "brcm,bcm2835-aux-spi";
-	reg = <0x7e2150c0 0x40>;
-	interrupts = <1 29>;
-	clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI2>;
-	#address-cells = <1>;
-	#size-cells = <0>;
-	cs-gpios = <&gpio 43>, <&gpio 44>, <&gpio 45>;
-};
diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
new file mode 100644
index 000000000..6df060778
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/brcm,bcm2835-aux-spi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM2835 Auxiliary SPI1/2 Controller
+
+maintainers:
+  - Karan Sanghavi <karansanghvi98@gmail.com>
+
+description:
+  The BCM2835 contains two forms of SPI master controller. One is known simply
+  as SPI0, and the other as the "Universal SPI Master," which is part of the
+  auxiliary block. This binding applies to the SPI1 and SPI2 auxiliary
+  controllers.
+
+allOf:
+  - $ref: spi-controller.yaml#
+
+properties:
+  compatible:
+    enum:
+      - brcm,bcm2835-aux-spi
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/bcm2835-aux.h>
+    spi@7e215080 {
+        compatible = "brcm,bcm2835-aux-spi";
+        reg = <0x7e215080 0x40>;
+        interrupts = <1 29>;
+        clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI1>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+    };
-- 
2.43.0
Re: [PATCH v4] spi: dt-bindings: brcm,bcm2835-aux-spi: Convert to dtschema
Posted by Mark Brown 1 month, 1 week ago
On Thu, 17 Oct 2024 15:02:16 +0000, Karan Sanghavi wrote:
> Convert bcm2835-aux-spi binding to Dt schema
> 
> Changes since v3:
>  - Updated the patch subject line
>  - Reformatted the description to fit within 80 characters
> 
> Changes since V2:
>  - Modified the Patch subject
>  - Removed unnecessary description and example
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: dt-bindings: brcm,bcm2835-aux-spi: Convert to dtschema
      commit: 4de1cdb3c299bb98d70198c1fa20c71f0893835c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: [PATCH v4] spi: dt-bindings: brcm,bcm2835-aux-spi: Convert to dtschema
Posted by Mark Brown 1 month, 1 week ago
On Thu, Oct 17, 2024 at 03:02:16PM +0000, Karan Sanghavi wrote:
> Convert bcm2835-aux-spi binding to Dt schema
> 
> Changes since v3:
>  - Updated the patch subject line
>  - Reformatted the description to fit within 80 characters

As covered in submitting-patches.rst inter-version changelogs go after
the ---.  There is no need to resubmit for this alone.