1. Patchew
  2. linux
  3. View series

[PATCH] Staging: rtl8723bs: Rename function SelectChannel()

vivek t s posted 1 patch 1 year, 3 months ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_ap.c          | 4 ++--
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 4 ++--
drivers/staging/rtl8723bs/core/rtw_wlan_util.c   | 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
[PATCH] Staging: rtl8723bs: Rename function SelectChannel()
Posted by vivek t s 1 year, 3 months ago 
Rename SelectChannel() to select_channel() to avoid
CamelCase warning from checkpatch.

compile tested.

Signed-off-by: vivek t s <vivek6429.ts@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c          | 4 ++--
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 4 ++--
 drivers/staging/rtl8723bs/core/rtw_wlan_util.c   | 2 +-
 drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index e4063713fecc..9bb1c5d9d5c2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -277,7 +277,7 @@ void expire_timeout_chk(struct adapter *padapter)
 		/* switch to correct channel of current network  before issue keep-alive frames */
 		if (rtw_get_oper_ch(padapter) != pmlmeext->cur_channel) {
 			backup_oper_channel = rtw_get_oper_ch(padapter);
-			SelectChannel(padapter, pmlmeext->cur_channel);
+			select_channel(padapter, pmlmeext->cur_channel);
 		}
 
 		/* issue null data to check sta alive*/
@@ -315,7 +315,7 @@ void expire_timeout_chk(struct adapter *padapter)
 		}
 
 		if (backup_oper_channel > 0) /* back to the original operation channel */
-			SelectChannel(padapter, backup_oper_channel);
+			select_channel(padapter, backup_oper_channel);
 	}
 
 	associated_clients_update(padapter, updated);
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 9ebf25a0ef9b..a79bb2930170 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -3831,10 +3831,10 @@ void site_survey(struct adapter *padapter)
 		} else {
 #ifdef DBG_FIXED_CHAN
 			if (pmlmeext->fixed_chan != 0xff)
-				SelectChannel(padapter, pmlmeext->fixed_chan);
+				select_channel(padapter, pmlmeext->fixed_chan);
 			else
 #endif
-				SelectChannel(padapter, survey_channel);
+				select_channel(padapter, survey_channel);
 		}
 
 		if (ScanType == SCAN_ACTIVE) { /* obey the channel plan setting... */
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 7fac9ca3e9a0..b45ac9156bc6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -333,7 +333,7 @@ inline unsigned long rtw_get_on_cur_ch_time(struct adapter *adapter)
 		return 0;
 }
 
-void SelectChannel(struct adapter *padapter, unsigned char channel)
+void select_channel(struct adapter *padapter, unsigned char channel)
 {
 	if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex)))
 		return;
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 720aeeb002b0..310352131e9a 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -455,7 +455,7 @@ u8 rtw_get_center_ch(u8 channel, u8 chnl_bw, u8 chnl_offset);
 unsigned long rtw_get_on_cur_ch_time(struct adapter *adapter);
 
 void set_channel_bwmode(struct adapter *padapter, unsigned char channel, unsigned char channel_offset, unsigned short bwmode);
-void SelectChannel(struct adapter *padapter, unsigned char channel);
+void select_channel(struct adapter *padapter, unsigned char channel);
 
 unsigned int decide_wait_for_beacon_timeout(unsigned int bcn_interval);
 
-- 
2.43.0
Re: [PATCH] Staging: rtl8723bs: Rename function SelectChannel()
Posted by Dan Carpenter 1 year, 3 months ago 
On Wed, Aug 28, 2024 at 03:04:57PM +0530, vivek t s wrote:
> Rename SelectChannel() to select_channel() to avoid
> CamelCase warning from checkpatch.

I wouldn't have commented on this except there are some other issues.
Line wrap your commit message at 72-75 characters (similar to email).
So "CamelCase warning" moves to the line before.

Rename SelectChannel() to select_channel() to avoid CamelCase warning
from checkpatch.

> 
> compile tested.
> 

Put this under the --- cut off.  (This is the real reason why I'm responding to
your patch)

> Signed-off-by: vivek t s <vivek6429.ts@gmail.com>

Your signed-off-by is like signing a legal document.  If you were buying a
house, then would you write your name like this?  If so then that's fine.

> ---
  ^^^
Cut off line here.

regards,
dan carpenter

>  drivers/staging/rtl8723bs/core/rtw_ap.c          | 4 ++--
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 4 ++--
>  drivers/staging/rtl8723bs/core/rtw_wlan_util.c   | 2 +-
>  drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
Re: [PATCH] Staging: rtl8723bs: Rename function SelectChannel()
Posted by Greg KH 1 year, 3 months ago 
On Wed, Aug 28, 2024 at 03:04:57PM +0530, vivek t s wrote:
> --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> @@ -455,7 +455,7 @@ u8 rtw_get_center_ch(u8 channel, u8 chnl_bw, u8 chnl_offset);
>  unsigned long rtw_get_on_cur_ch_time(struct adapter *adapter);
>  
>  void set_channel_bwmode(struct adapter *padapter, unsigned char channel, unsigned char channel_offset, unsigned short bwmode);
> -void SelectChannel(struct adapter *padapter, unsigned char channel);
> +void select_channel(struct adapter *padapter, unsigned char channel);

This is a pretty horrible name for a symbol in the global namespace, can
you rename it to be more sane for this driver (i.e. put a prefix on it?)

thanks,

greg k-h
Re: [PATCH] Staging: rtl8723bs: Rename function SelectChannel()
Posted by YOUR NAME 1 year, 3 months ago 
On Wed, Aug 28, 2024 at 11:38:18AM +0200, Greg KH wrote:
> On Wed, Aug 28, 2024 at 03:04:57PM +0530, vivek t s wrote:
> > --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> > +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> > @@ -455,7 +455,7 @@ u8 rtw_get_center_ch(u8 channel, u8 chnl_bw, u8 chnl_offset);
> >  unsigned long rtw_get_on_cur_ch_time(struct adapter *adapter);
> >  
> >  void set_channel_bwmode(struct adapter *padapter, unsigned char channel, unsigned char channel_offset, unsigned short bwmode);
> > -void SelectChannel(struct adapter *padapter, unsigned char channel);
> > +void select_channel(struct adapter *padapter, unsigned char channel);
> 
> This is a pretty horrible name for a symbol in the global namespace, can
> you rename it to be more sane for this driver (i.e. put a prefix on it?)
> 
> thanks,
> 
> greg k-h
okay, will change and submit again.

thanks,
vivek

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.