.../devicetree/bindings/hwmon/ti,tmp108.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)
TMP108 is powered by its V+ supply, document it.
While at it, add a short description with a link to its datasheets.
Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
Not entirely sure of the "v+-supply" name, but the datasheet only ever
refers to it as "V+" or simply as the "supply voltage".
Only other name I've seen is in the schematic for the msm8226-based
motorola-falcon smartphone, where it's called "V_POS".
.../devicetree/bindings/hwmon/ti,tmp108.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
index 8b5307c875ff..71d3b51d24d1 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
@@ -9,6 +9,14 @@ title: TMP108 temperature sensor
maintainers:
- Krzysztof Kozlowski <krzk@kernel.org>
+description: |
+ The TMP108 is a digital-output temperature sensor with a
+ dynamically-programmable limit window, and under- and overtemperature
+ alert functions.
+
+ Datasheets:
+ https://www.ti.com/product/TMP108
+
properties:
compatible:
enum:
@@ -24,6 +32,8 @@ properties:
"#thermal-sensor-cells":
const: 0
+ v+-supply: true
+
required:
- compatible
- reg
@@ -45,6 +55,7 @@ examples:
interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&tmp_alrt>;
+ v+-supply = <&supply>;
#thermal-sensor-cells = <0>;
};
};
--
2.34.1
On 6/16/24 12:40, Stanislav Jakubek wrote: > TMP108 is powered by its V+ supply, document it. > While at it, add a short description with a link to its datasheets. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > --- > Not entirely sure of the "v+-supply" name, but the datasheet only ever > refers to it as "V+" or simply as the "supply voltage". > Only other name I've seen is in the schematic for the msm8226-based > motorola-falcon smartphone, where it's called "V_POS". > Guess one has to praise the ability of datasheet writers to come up with different names. The datasheet for tmp117 also uses the V+ term, yet the supply name is "vcc-supply". I would personally very much prefer to stick with that, but that is just my personal opinion. Guenter
On Sun, Jun 16, 2024 at 01:43:08PM -0700, Guenter Roeck wrote: > On 6/16/24 12:40, Stanislav Jakubek wrote: > > TMP108 is powered by its V+ supply, document it. > > While at it, add a short description with a link to its datasheets. > > > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > > --- > > Not entirely sure of the "v+-supply" name, but the datasheet only ever > > refers to it as "V+" or simply as the "supply voltage". > > Only other name I've seen is in the schematic for the msm8226-based > > motorola-falcon smartphone, where it's called "V_POS". > > > > Guess one has to praise the ability of datasheet writers to come up > with different names. > > The datasheet for tmp117 also uses the V+ term, yet the supply name > is "vcc-supply". I would personally very much prefer to stick with that, > but that is just my personal opinion. > > Guenter > I'm okay with that. I'll keep this for a few days to see if anyone else has anything to say, then I'll send a V2 with it changed to vcc. Stanislav
On 17/06/2024 07:09, Stanislav Jakubek wrote: > On Sun, Jun 16, 2024 at 01:43:08PM -0700, Guenter Roeck wrote: >> On 6/16/24 12:40, Stanislav Jakubek wrote: >>> TMP108 is powered by its V+ supply, document it. >>> While at it, add a short description with a link to its datasheets. >>> >>> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> >>> --- >>> Not entirely sure of the "v+-supply" name, but the datasheet only ever >>> refers to it as "V+" or simply as the "supply voltage". >>> Only other name I've seen is in the schematic for the msm8226-based >>> motorola-falcon smartphone, where it's called "V_POS". >>> >> >> Guess one has to praise the ability of datasheet writers to come up >> with different names. >> >> The datasheet for tmp117 also uses the V+ term, yet the supply name >> is "vcc-supply". I would personally very much prefer to stick with that, >> but that is just my personal opinion. >> >> Guenter >> > > I'm okay with that. I'll keep this for a few days to see if anyone else > has anything to say, then I'll send a V2 with it changed to vcc. vcc. Anyway + is not an expected character. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.