drivers/staging/vme_user/vme.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Fixed all CHECK: Unbalanced braces around else statement,
CHECK: braces {} should be used on all arms of this statement,
and CHECK: 'specificed' may be misspelled - perhaps 'specified'?
as reported by checkpatch to adhere to the Linux kernel
coding-style guidelines.
Signed-off-by: Alexon Oliveira <alexondunkan@gmail.com>
---
drivers/staging/vme_user/vme.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index d0366dd3f2b1..1e11047acf54 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -1620,7 +1620,7 @@ EXPORT_SYMBOL(vme_lm_get);
* @callback: Pointer to callback function called when triggered.
* @data: Generic pointer that will be passed to the callback function.
*
- * Attach a callback to the specificed offset into the location monitors
+ * Attach a callback to the specified offset into the location monitors
* monitored addresses. A generic pointer is provided to allow data to be
* passed to the callback when called.
*
@@ -1655,7 +1655,7 @@ EXPORT_SYMBOL(vme_lm_attach);
* @resource: Pointer to VME location monitor resource.
* @monitor: Offset to which callback should be removed.
*
- * Remove the callback associated with the specificed offset into the
+ * Remove the callback associated with the specified offset into the
* location monitors monitored addresses.
*
* Return: Zero on success, -EINVAL when provided with an invalid location
@@ -1866,8 +1866,9 @@ static int __vme_register_driver_bus(struct vme_driver *drv,
if (vdev->dev.platform_data) {
list_add_tail(&vdev->drv_list, &drv->devices);
list_add_tail(&vdev->bridge_list, &bridge->devices);
- } else
+ } else {
device_unregister(&vdev->dev);
+ }
}
return 0;
--
2.41.0
On Tue, Aug 22, 2023 at 10:40:12PM -0300, Alexon Oliveira wrote:
> Fixed all CHECK: Unbalanced braces around else statement,
> CHECK: braces {} should be used on all arms of this statement,
> and CHECK: 'specificed' may be misspelled - perhaps 'specified'?
> as reported by checkpatch to adhere to the Linux kernel
> coding-style guidelines.
That's two different things, so that means it should be two different
patches. Please send a patch series for this.
thanks,
greg k-h
On Wed, Aug 23, 2023 at 08:49:25AM +0200, Greg KH wrote:
> On Tue, Aug 22, 2023 at 10:40:12PM -0300, Alexon Oliveira wrote:
> > Fixed all CHECK: Unbalanced braces around else statement,
> > CHECK: braces {} should be used on all arms of this statement,
> > and CHECK: 'specificed' may be misspelled - perhaps 'specified'?
> > as reported by checkpatch to adhere to the Linux kernel
> > coding-style guidelines.
>
> That's two different things, so that means it should be two different
> patches. Please send a patch series for this.
>
ACK. I'm splitting them and resubmitting right now.
> thanks,
>
> greg k-h
Thank you.
Alexon Oliveira
© 2016 - 2025 Red Hat, Inc.