f2fs: set zstd default compression level to ZSTD_CLEVEL_DEFAULT

[PATCH] f2fs: set zstd default compression level to ZSTD_CLEVEL_DEFAULT

Posted by Jaegeuk Kim 2 years, 8 months ago

ZSTD does not support compress_level=0.

The commit d7ffafc99c42 ("f2fs: add sanity compress level check for compressed file")
started to complain this.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
Change log from v1:
 - use default macro

 fs/f2fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 8fd23caa1ed9..ce3b628b5072 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -627,7 +627,7 @@ static int f2fs_set_zstd_level(struct f2fs_sb_info *sbi, const char *str)
 	int len = 4;
 
 	if (strlen(str) == len) {
-		F2FS_OPTION(sbi).compress_level = 0;
+		F2FS_OPTION(sbi).compress_level = ZSTD_CLEVEL_DEFAULT;
 		return 0;
 	}
 
-- 
2.41.0.162.gfafddb0af9-goog

Re: [f2fs-dev] [PATCH] f2fs: set zstd default compression level to ZSTD_CLEVEL_DEFAULT

Posted by Chao Yu 2 years, 7 months ago

On 2023/6/12 23:17, Jaegeuk Kim wrote:
> ZSTD does not support compress_level=0.
> 
> The commit d7ffafc99c42 ("f2fs: add sanity compress level check for compressed file")
> started to complain this.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

Re: [f2fs-dev] [PATCH] f2fs: set zstd default compression level to ZSTD_CLEVEL_DEFAULT

Posted by Jaegeuk Kim 2 years, 7 months ago

On 06/13, Chao Yu wrote:
> On 2023/6/12 23:17, Jaegeuk Kim wrote:
> > ZSTD does not support compress_level=0.
> > 
> > The commit d7ffafc99c42 ("f2fs: add sanity compress level check for compressed file")
> > started to complain this.
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> 
> Reviewed-by: Chao Yu <chao@kernel.org>

Final version:
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=e59031a552b5cbda098a7ee421ec56bd084dfd4d

> 
> Thanks,