[PATCH] rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <ojeda@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1002

Roy Matero posted 1 patch 2 years, 7 months ago
rust/bindings/bindings_helper.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <ojeda@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1002
Posted by Roy Matero 2 years, 7 months ago
Signed-off-by: Roy Matero <materoy@proton.me>
---
 rust/bindings/bindings_helper.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
index 50e7a76d5455..dc8d97272e71 100644
--- a/rust/bindings/bindings_helper.h
+++ b/rust/bindings/bindings_helper.h
@@ -6,10 +6,10 @@
  * Sorted alphabetically.
  */

-#include <linux/slab.h>
 #include <linux/refcount.h>
-#include <linux/wait.h>
 #include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/wait.h>

 /* `bindgen` gets confused at certain things. */
 const gfp_t BINDINGS_GFP_KERNEL = GFP_KERNEL;
--
2.40.1
Re: [PATCH] rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <ojeda@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1002
Posted by Miguel Ojeda 2 years, 7 months ago
On Wed, Apr 26, 2023 at 11:46 PM Roy Matero <materoy@proton.me> wrote:
>
> Signed-off-by: Roy Matero <materoy@proton.me>

Thank you for the patch!

Something strange happened -- it looks like the body went into the
subject line. Did you use `git-send-email`?

Also, please use a dash in `Suggested-by` and a title like "rust:
bindings: sort includes". Also, please add a commit description --
please see Ariel's recent patch [1] and discussion for some more
details.

[1] https://lore.kernel.org/rust-for-linux/20230426204923.16195-1-amiculas@cisco.com/

Cheers,
Miguel