1. Patchew
  2. linux
  3. View series

[PATCH] hwrng: Kconfig - Add HAS_IOMEM dependencies for exynos/meson/mtk/npcm

Herbert Xu posted 1 patch 2 years, 8 months ago
[PATCH] hwrng: Kconfig - Add HAS_IOMEM dependencies for exynos/meson/mtk/npcm
Posted by Herbert Xu 2 years, 8 months ago 
On Wed, Apr 19, 2023 at 11:43:42AM +0800, kernel test robot wrote:
>
>    s390-linux-ld: drivers/char/hw_random/exynos-trng.o: in function `exynos_trng_probe':
>    exynos-trng.c:(.text+0x39e): undefined reference to `devm_platform_ioremap_resource'
>    s390-linux-ld: drivers/char/hw_random/meson-rng.o: in function `meson_rng_probe':
>    meson-rng.c:(.text+0x10a): undefined reference to `devm_platform_ioremap_resource'
>    s390-linux-ld: drivers/char/hw_random/mtk-rng.o: in function `mtk_rng_probe':
>    mtk-rng.c:(.text+0x40e): undefined reference to `devm_platform_ioremap_resource'
>    s390-linux-ld: drivers/char/hw_random/npcm-rng.o: in function `npcm_rng_probe':
>    npcm-rng.c:(.text+0x2ca): undefined reference to `devm_platform_ioremap_resource'

OK, this patch should fix these ones at least:

---8<---
Add missing dependencies on HAS_IOMEM as otherwise they will trigger
failed builds with COMPILE_TEST enabled.

Also add dependencies on OF where appropriate.

Change the default so that these drivers are not enabled just because
COMPILE_TEST is turned on.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304191106.swKbBeDh-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index ae508e96cfc2..f3146470ce88 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -400,9 +400,9 @@ config HW_RANDOM_POLARFIRE_SOC
 
 config HW_RANDOM_MESON
 	tristate "Amlogic Meson Random Number Generator support"
-	depends on HW_RANDOM
 	depends on ARCH_MESON || COMPILE_TEST
-	default y
+	depends on HAS_IOMEM && OF
+	default HW_RANDOM if ARCH_MESON
 	help
 	  This driver provides kernel-side support for the Random Number
 	  Generator hardware found on Amlogic Meson SoCs.
@@ -427,9 +427,9 @@ config HW_RANDOM_CAVIUM
 
 config HW_RANDOM_MTK
 	tristate "Mediatek Random Number Generator support"
-	depends on HW_RANDOM
 	depends on ARCH_MEDIATEK || COMPILE_TEST
-	default y
+	depends on HAS_IOMEM && OF
+	default HW_RANDOM if ARCH_MEDIATEK
 	help
 	  This driver provides kernel-side support for the Random Number
 	  Generator hardware found on Mediatek SoCs.
@@ -456,7 +456,8 @@ config HW_RANDOM_S390
 config HW_RANDOM_EXYNOS
 	tristate "Samsung Exynos True Random Number Generator support"
 	depends on ARCH_EXYNOS || COMPILE_TEST
-	default HW_RANDOM
+	depends on HAS_IOMEM
+	default HW_RANDOM if ARCH_EXYNOS
 	help
 	  This driver provides support for the True Random Number
 	  Generator available in Exynos SoCs.
@@ -483,7 +484,8 @@ config HW_RANDOM_OPTEE
 config HW_RANDOM_NPCM
 	tristate "NPCM Random Number Generator support"
 	depends on ARCH_NPCM || COMPILE_TEST
-	default HW_RANDOM
+	depends on HAS_IOMEM
+	default HW_RANDOM if ARCH_NPCM
 	help
 	  This driver provides support for the Random Number
 	  Generator hardware available in Nuvoton NPCM SoCs.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH] hwrng: Kconfig - Add HAS_IOMEM dependencies for exynos/meson/mtk/npcm
Posted by Lukasz Stelmach 2 years, 7 months ago 
It was <2023-04-19 śro 16:37>, when Herbert Xu wrote:
> On Wed, Apr 19, 2023 at 11:43:42AM +0800, kernel test robot wrote:
>>
>>    s390-linux-ld: drivers/char/hw_random/exynos-trng.o: in function `exynos_trng_probe':
>>    exynos-trng.c:(.text+0x39e): undefined reference to `devm_platform_ioremap_resource'
>>    s390-linux-ld: drivers/char/hw_random/meson-rng.o: in function `meson_rng_probe':
>>    meson-rng.c:(.text+0x10a): undefined reference to `devm_platform_ioremap_resource'
>>    s390-linux-ld: drivers/char/hw_random/mtk-rng.o: in function `mtk_rng_probe':
>>    mtk-rng.c:(.text+0x40e): undefined reference to `devm_platform_ioremap_resource'
>>    s390-linux-ld: drivers/char/hw_random/npcm-rng.o: in function `npcm_rng_probe':
>>    npcm-rng.c:(.text+0x2ca): undefined reference to `devm_platform_ioremap_resource'
>
> OK, this patch should fix these ones at least:
>
> ---8<---
> Add missing dependencies on HAS_IOMEM as otherwise they will trigger
> failed builds with COMPILE_TEST enabled.
>
> Also add dependencies on OF where appropriate.
>
> Change the default so that these drivers are not enabled just because
> COMPILE_TEST is turned on.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304191106.swKbBeDh-lkp@intel.com/
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>

Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index ae508e96cfc2..f3146470ce88 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -400,9 +400,9 @@ config HW_RANDOM_POLARFIRE_SOC
>  
>  config HW_RANDOM_MESON
>  	tristate "Amlogic Meson Random Number Generator support"
> -	depends on HW_RANDOM
>  	depends on ARCH_MESON || COMPILE_TEST
> -	default y
> +	depends on HAS_IOMEM && OF
> +	default HW_RANDOM if ARCH_MESON
>  	help
>  	  This driver provides kernel-side support for the Random Number
>  	  Generator hardware found on Amlogic Meson SoCs.
> @@ -427,9 +427,9 @@ config HW_RANDOM_CAVIUM
>  
>  config HW_RANDOM_MTK
>  	tristate "Mediatek Random Number Generator support"
> -	depends on HW_RANDOM
>  	depends on ARCH_MEDIATEK || COMPILE_TEST
> -	default y
> +	depends on HAS_IOMEM && OF
> +	default HW_RANDOM if ARCH_MEDIATEK
>  	help
>  	  This driver provides kernel-side support for the Random Number
>  	  Generator hardware found on Mediatek SoCs.
> @@ -456,7 +456,8 @@ config HW_RANDOM_S390
>  config HW_RANDOM_EXYNOS
>  	tristate "Samsung Exynos True Random Number Generator support"
>  	depends on ARCH_EXYNOS || COMPILE_TEST
> -	default HW_RANDOM
> +	depends on HAS_IOMEM
> +	default HW_RANDOM if ARCH_EXYNOS
>  	help
>  	  This driver provides support for the True Random Number
>  	  Generator available in Exynos SoCs.
> @@ -483,7 +484,8 @@ config HW_RANDOM_OPTEE
>  config HW_RANDOM_NPCM
>  	tristate "NPCM Random Number Generator support"
>  	depends on ARCH_NPCM || COMPILE_TEST
> -	default HW_RANDOM
> +	depends on HAS_IOMEM
> +	default HW_RANDOM if ARCH_NPCM
>  	help
>  	  This driver provides support for the Random Number
>  	  Generator hardware available in Nuvoton NPCM SoCs.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.