[v1] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning

[PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning

Posted by Gustavo A. R. Silva 9 months, 1 week ago

Fix the following warning by removing unused flex-array member
`data` in `struct bcm_vk_peer_log`:

drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/misc/bcm-vk/bcm_vk.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/bcm-vk/bcm_vk.h b/drivers/misc/bcm-vk/bcm_vk.h
index 386884c2a263..9344c2366a4b 100644
--- a/drivers/misc/bcm-vk/bcm_vk.h
+++ b/drivers/misc/bcm-vk/bcm_vk.h
@@ -311,7 +311,6 @@ struct bcm_vk_peer_log {
 	u32 wr_idx;
 	u32 buf_size;
 	u32 mask;
-	char data[];
 };
 
 /* max buf size allowed */
-- 
2.43.0

Re: [PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning

Posted by Scott Branden 9 months, 1 week ago

looks fine

On 2025-03-13 15:36, Gustavo A. R. Silva wrote:
> Fix the following warning by removing unused flex-array member
> `data` in `struct bcm_vk_peer_log`:
> 
> drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
>   drivers/misc/bcm-vk/bcm_vk.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/misc/bcm-vk/bcm_vk.h b/drivers/misc/bcm-vk/bcm_vk.h
> index 386884c2a263..9344c2366a4b 100644
> --- a/drivers/misc/bcm-vk/bcm_vk.h
> +++ b/drivers/misc/bcm-vk/bcm_vk.h
> @@ -311,7 +311,6 @@ struct bcm_vk_peer_log {
>   	u32 wr_idx;
>   	u32 buf_size;
>   	u32 mask;
> -	char data[];
>   };
>   
>   /* max buf size allowed */

Re: [PATCH][next] misc: bcm-vk: avoid -Wflex-array-member-not-at-end warning

Posted by Gustavo A. R. Silva 9 months, 1 week ago


On 14/03/25 10:34, Scott Branden wrote:
> looks fine
> 
> On 2025-03-13 15:36, Gustavo A. R. Silva wrote:
>> Fix the following warning by removing unused flex-array member
>> `data` in `struct bcm_vk_peer_log`:
>>
>> drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at- 
>> end]
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> Acked-by: Scott Branden <scott.branden@broadcom.com>

Thanks! :)

--
Gustavo