staging: gpib: format no multiple blank lines

[PATCH] staging: gpib: format no multiple blank lines

Posted by Ian To 1 year ago

Avoid adding multiple blank lines. Reported by checkpatch.

Signed-off-by: Ian To <onlyian4981@gmail.com>
---
 drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/hp_82341/hp_82341.h b/drivers/staging/gpib/hp_82341/hp_82341.h
index 0065ebd9747c..d3cf1f43a1ef 100644
--- a/drivers/staging/gpib/hp_82341/hp_82341.h
+++ b/drivers/staging/gpib/hp_82341/hp_82341.h
@@ -26,7 +26,6 @@ struct hp_82341_priv {
 	enum hp_82341_hardware_version hw_version;
 };
 
-
 // interface functions
 int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
 			size_t *bytes_read);
-- 
2.45.3

Re: [PATCH] staging: gpib: format no multiple blank lines

Posted by Greg KH 1 year ago

On Fri, Jan 31, 2025 at 12:22:33AM -0800, Ian To wrote:
> Avoid adding multiple blank lines. Reported by checkpatch.
> 
> Signed-off-by: Ian To <onlyian4981@gmail.com>
> ---
>  drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/gpib/hp_82341/hp_82341.h b/drivers/staging/gpib/hp_82341/hp_82341.h
> index 0065ebd9747c..d3cf1f43a1ef 100644
> --- a/drivers/staging/gpib/hp_82341/hp_82341.h
> +++ b/drivers/staging/gpib/hp_82341/hp_82341.h
> @@ -26,7 +26,6 @@ struct hp_82341_priv {
>  	enum hp_82341_hardware_version hw_version;
>  };
>  
> -
>  // interface functions
>  int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
>  			size_t *bytes_read);
> -- 
> 2.45.3
> 
> 

Does not apply cleanly to 6.14-rc1 :(

Re: [PATCH] staging: gpib: format no multiple blank lines

Posted by Dave Penkler 1 year ago

On Mon, Feb 03, 2025 at 04:09:45PM +0100, Greg KH wrote:
> On Fri, Jan 31, 2025 at 12:22:33AM -0800, Ian To wrote:
> > Avoid adding multiple blank lines. Reported by checkpatch.
> > 
> > Signed-off-by: Ian To <onlyian4981@gmail.com>
> > ---
> >  drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gpib/hp_82341/hp_82341.h b/drivers/staging/gpib/hp_82341/hp_82341.h
> > index 0065ebd9747c..d3cf1f43a1ef 100644
> > --- a/drivers/staging/gpib/hp_82341/hp_82341.h
> > +++ b/drivers/staging/gpib/hp_82341/hp_82341.h
> > @@ -26,7 +26,6 @@ struct hp_82341_priv {
> >  	enum hp_82341_hardware_version hw_version;
> >  };
> >  
> > -
> >  // interface functions
> >  int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
> >  			size_t *bytes_read);
> > -- 
> > 2.45.3
> > 
> > 
> 
> Does not apply cleanly to 6.14-rc1 :(
An earlier patch, commit 8418753187ba ("staging: gpib: Make static, reduce fwd declarations") changed this file. It is at this point checkpatch clean.
cheers,
-dave