[PATCH] staging: comedi: add blank line after declarations

Ian To posted 1 patch 1 year ago
drivers/staging/comedi/comedi_fops.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH] staging: comedi: add blank line after declarations
Posted by Ian To 1 year ago
gregkh@linuxfoundation.org  
Cc: devel@driverdev.osuosl.org linux-kernel@vger.kernel.org
Bcc: 
Subject: [PATCH] staging: comedi: add blank line after declarations
Reply-To: 

Added blank lines after declarations. Reported by checkpatch.

Signed-off-by: Ian To <onlyian4981@gmail.com>
---
 drivers/staging/comedi/comedi_fops.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index e85a99b68f31..3f70e5dfac39 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2169,6 +2169,7 @@ static long comedi_unlocked_ioctl(struct file *file, unsigned int cmd,
 		break;
 	case COMEDI_CHANINFO: {
 		struct comedi_chaninfo it;
+
 		if (copy_from_user(&it, (void __user *)arg, sizeof(it)))
 			rc = -EFAULT;
 		else
@@ -2177,6 +2178,7 @@ static long comedi_unlocked_ioctl(struct file *file, unsigned int cmd,
 	}
 	case COMEDI_RANGEINFO: {
 		struct comedi_rangeinfo it;
+
 		if (copy_from_user(&it, (void __user *)arg, sizeof(it)))
 			rc = -EFAULT;
 		else
@@ -2249,6 +2251,7 @@ static long comedi_unlocked_ioctl(struct file *file, unsigned int cmd,
 	}
 	case COMEDI_INSN: {
 		struct comedi_insn insn;
+
 		if (copy_from_user(&insn, (void __user *)arg, sizeof(insn)))
 			rc = -EFAULT;
 		else
-- 
2.45.3
Re: [PATCH] staging: comedi: add blank line after declarations
Posted by Greg KH 1 year ago
On Thu, Jan 30, 2025 at 02:33:27PM -0800, Ian To wrote:
> gregkh@linuxfoundation.org  
> Cc: devel@driverdev.osuosl.org linux-kernel@vger.kernel.org
> Bcc: 
> Subject: [PATCH] staging: comedi: add blank line after declarations
> Reply-To: 

Something went wrong with your email submission here, please fix up and
try again.

Also:

> Added blank lines after declarations. Reported by checkpatch.
> 
> Signed-off-by: Ian To <onlyian4981@gmail.com>
> ---
>  drivers/staging/comedi/comedi_fops.c | 3 +++

This file is not in the kernel tree right now, are you sure you are
working on the proper kernel version to do development with?

thanks,

greg k-h